From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: [PATCH v2 1/3] highlight: add workaround for empty lines getting filtered out
Date: Tue, 21 Feb 2012 15:23:41 +0100 [thread overview]
Message-ID: <20120221142341.GB28585@blizzard> (raw)
In-Reply-To: <4F439FDE.6090107@hupie.com>
On Tue, Feb 21, 2012 at 02:45:02PM +0100, Ferry Huberts wrote:
>
>
> On 21-02-12 14:16, Lukas Fleischer wrote:
> >On Tue, Feb 21, 2012 at 01:13:29PM +0100, Ferry Huberts wrote:
> >>From: Ferry Huberts<ferry.huberts at pelagic.nl>
> >>
> >>Saw this happening on a CentOS 6.2 box
> >>
> >>Signed-off-by: Ferry Huberts<ferry.huberts at pelagic.nl>
> >>---
> >> filters/syntax-highlighting.sh | 3 ++-
> >> 1 files changed, 2 insertions(+), 1 deletions(-)
> >>
> >>diff --git a/filters/syntax-highlighting.sh b/filters/syntax-highlighting.sh
> >>index 6283ce9..c930e07 100755
> >>--- a/filters/syntax-highlighting.sh
> >>+++ b/filters/syntax-highlighting.sh
> >>@@ -42,4 +42,5 @@ EXTENSION="${BASENAME##*.}"
> >> # map Makefile and Makefile.* to .mk
> >> [ "${BASENAME%%.*}" == "Makefile" ]&& EXTENSION=mk
> >>
> >>-exec highlight --force -f -I -X -S $EXTENSION 2>/dev/null
> >>+# the sed with is a workaround for empty lines getting filtered out
> >>+exec highlight --force -f -I -X -S $EXTENSION 2>/dev/null | sed -r 's/^[[:space:]]*$/\ /'
> >
> >I'm not sure what you're trying to fix here. The whole output of source
> >filters is always embedded in "pre" containers, so there shouldn't be
> >any need to replace spaces by " ", really. This rather sounds like
> >a bug in your rendering engine...
> >
>
> same firefox instance...
> I've tried to trace it but didn't come to a conclusive answer
Just have a look at the HTML source and check whether it contains the
empty lines. If it doesn't, this is a highlight(1) bug. If it does, it
clearly is a bug in your rendering engine.
>
>
> --
> Ferry Huberts
next prev parent reply other threads:[~2012-02-21 14:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 12:13 mailings
2012-02-21 12:13 ` [PATCH v2 2/3] highlight: declare variables mailings
2012-02-21 13:23 ` cgit
2012-02-21 12:13 ` [PATCH v2 3/3] highlight: fix syntax highlighting for program versions > 2 mailings
2012-02-21 13:27 ` cgit
2012-02-21 13:47 ` mailings
2012-02-21 14:21 ` cgit
2012-02-21 13:16 ` [PATCH v2 1/3] highlight: add workaround for empty lines getting filtered out cgit
2012-02-21 13:45 ` mailings
2012-02-21 14:23 ` cgit [this message]
2012-02-21 15:21 ` mailings
2012-02-21 18:41 ` mailings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120221142341.GB28585@blizzard \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).