From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: [PATCH] add TITLE to log commit entries
Date: Wed, 14 Mar 2012 23:03:50 +0100 [thread overview]
Message-ID: <20120314220350.GA31079@blizzard> (raw)
In-Reply-To: <CALXrvzA40xXy3LjzWwVYTBY=sWzkS354Zfz9diWSWCm4_iVXqA@mail.gmail.com>
On Fri, Mar 02, 2012 at 04:08:59PM -0600, Josef wells wrote:
> ---
> ui-shared.c | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/ui-shared.c b/ui-shared.c
> index 3e9282f..305342d 100644
> --- a/ui-shared.c
> +++ b/ui-shared.c
> @@ -360,7 +360,12 @@ void cgit_commit_link(char *name, const char
> *title, const char *class,
> html("ignorews=1");
> delim = "&";
> }
> - html("'>");
> + html("' ");
I know I'm nitpicking but I'd rather go with moving 'html("'>");' to an
else branch to the if-block below. Benefit: No unneeded space and
html() is only called once (instead of twice).
> + if (rev && strcmp(rev, ctx.qry.head)) {
> + html("TITLE=");
> + html_url_arg(rev);
This looks wrong:
1. Lowercase attributes, please. We're not using uppercase anywhere.
2. Quote the attribute value.
3. html_url_arg() isn't the right function. Use html_attr() instead.
> + }
> + html(">");
> html_txt(name);
> html("</a>");
> }
> --
> 1.7.7.3
>
> _______________________________________________
> cgit mailing list
> cgit at hjemli.net
> http://hjemli.net/mailman/listinfo/cgit
next prev parent reply other threads:[~2012-03-14 22:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 22:08 Josefwells
2012-03-14 22:03 ` cgit [this message]
2012-03-18 9:55 ` hjemli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120314220350.GA31079@blizzard \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).