List for cgit developers and users
 help / color / mirror / Atom feed
From: larsh at hjemli.net (larsh at hjemli.net)
Subject: [PATCH v1 RESEND 2/3] css: vertically align the cgit logo image
Date: Sun, 18 Mar 2012 11:28:12 +0000	[thread overview]
Message-ID: <20120318112812.GG15839@hjemli.net> (raw)
In-Reply-To: <4F65BFD9.3060809@hupie.com>

On Sun, Mar 18, 2012 at 11:58:33AM +0100, Ferry Huberts wrote:
> 
> 
> On 18-03-12 12:03, larsh at hjemli.net wrote:
> >On Sun, Mar 18, 2012 at 11:44:04AM +0100, Ferry Huberts wrote:
> >>From: Ferry Huberts<ferry.huberts at pelagic.nl>
> >>
> >>Signed-off-by: Ferry Huberts<ferry.huberts at pelagic.nl>
> >>---
> >>  cgit.css |    1 +
> >>  1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >>diff --git a/cgit.css b/cgit.css
> >>index 4b79c1c..51b04fe 100644
> >>--- a/cgit.css
> >>+++ b/cgit.css
> >>@@ -31,6 +31,7 @@ div#cgit table#header {
> >>
> >>  div#cgit table#header td.logo {
> >>  	width: 96px;
> >>+	vertical-align: top;
> >>  }
> >Why is this needed?
> 
> I have written a trac plugin that embeds cgit,

Cool.

> and the logo is placement 
> is completely off when not doing this

Ok. I don't mind specifying a value for vertical-align, I just needed a
rationale. Will apply with amended commit message.

--
larsh




  parent reply	other threads:[~2012-03-18 11:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-18 10:44 [PATCH v1 RESEND 1/3] css: prefix all styles with div#cgit mailings
2012-03-18 10:44 ` [PATCH v1 RESEND 2/3] css: vertically align the cgit logo image mailings
2012-03-18 11:03   ` larsh
     [not found]     ` <4F65BFD9.3060809@hupie.com>
2012-03-18 11:28       ` larsh [this message]
2012-03-18 11:24         ` mailings
2012-03-18 10:44 ` [PATCH v1 RESEND 3/3] css: force text color to black on decorations mailings
2012-03-18 11:06   ` larsh
2012-03-18 11:00 ` [PATCH v1 RESEND 1/3] css: prefix all styles with div#cgit larsh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120318112812.GG15839@hjemli.net \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).