From mboxrd@z Thu Jan 1 00:00:00 1970 From: larsh at hjemli.net (larsh at hjemli.net) Date: Sun, 18 Mar 2012 11:28:12 +0000 Subject: [PATCH v1 RESEND 2/3] css: vertically align the cgit logo image In-Reply-To: <4F65BFD9.3060809@hupie.com> References: <1332067445-14943-1-git-send-email-mailings@hupie.com> <1332067445-14943-2-git-send-email-mailings@hupie.com> <20120318110312.GD15839@hjemli.net> <4F65BFD9.3060809@hupie.com> Message-ID: <20120318112812.GG15839@hjemli.net> On Sun, Mar 18, 2012 at 11:58:33AM +0100, Ferry Huberts wrote: > > > On 18-03-12 12:03, larsh at hjemli.net wrote: > >On Sun, Mar 18, 2012 at 11:44:04AM +0100, Ferry Huberts wrote: > >>From: Ferry Huberts > >> > >>Signed-off-by: Ferry Huberts > >>--- > >> cgit.css | 1 + > >> 1 files changed, 1 insertions(+), 0 deletions(-) > >> > >>diff --git a/cgit.css b/cgit.css > >>index 4b79c1c..51b04fe 100644 > >>--- a/cgit.css > >>+++ b/cgit.css > >>@@ -31,6 +31,7 @@ div#cgit table#header { > >> > >> div#cgit table#header td.logo { > >> width: 96px; > >>+ vertical-align: top; > >> } > >Why is this needed? > > I have written a trac plugin that embeds cgit, Cool. > and the logo is placement > is completely off when not doing this Ok. I don't mind specifying a value for vertical-align, I just needed a rationale. Will apply with amended commit message. -- larsh