From: larsh at hjemli.net (larsh at hjemli.net)
Subject: [PATCH] Updated css to better looking blob line numbers
Date: Tue, 20 Mar 2012 08:08:58 +0000 [thread overview]
Message-ID: <20120320080858.GB9012@hjemli.net> (raw)
In-Reply-To: <4F6791D6.9050402@gmail.com>
On Mon, Mar 19, 2012 at 09:06:46PM +0100, Mariusz Wojcik wrote:
> ---
> cgit.css | 11 ++++++-----
> 1 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/cgit.css b/cgit.css
> index e06c261..1cc4921 100644
> --- a/cgit.css
> +++ b/cgit.css
> @@ -274,7 +274,7 @@ div#cgit td.ls-mode {
> div#cgit table.blob {
> margin-top: 0.5em;
> - border-top: solid 1px black;
> + border: solid 1px #ccc;
> }
> div#cgit table.blob td.lines {
> @@ -287,7 +287,8 @@ div#cgit table.blob td.linenumbers {
> margin: 0; padding: 0 0.5em 0 0.5em;
> vertical-align: top;
> text-align: right;
> - border-right: 1px solid gray;
> + border-right: 1px solid #ccc;
> + background-color: #eee;
> }
> div#cgit table.blob pre {
> @@ -306,20 +307,20 @@ div#cgit table.blob a.no a:hover {
> div#cgit table.bin-blob {
> margin-top: 0.5em;
> - border: solid 1px black;
> + border: solid 1px #ccc;
> }
> div#cgit table.bin-blob th {
> font-family: monospace;
> white-space: pre;
> - border: solid 1px #777;
> + border: solid 1px #ccc;
> padding: 0.5em 1em;
> }
> div#cgit table.bin-blob td {
> font-family: monospace;
> white-space: pre;
> - border-left: solid 1px #777;
> + border-left: solid 1px #ccc;
> padding: 0em 1em;
> }
I'd actually prefer less boxes in the cgit pages, maybe something like
this:
diff --git a/cgit.css b/cgit.css
index e06c261..0e99f61 100644
--- a/cgit.css
+++ b/cgit.css
@@ -273,8 +273,7 @@ div#cgit td.ls-mode {
}
div#cgit table.blob {
- margin-top: 0.5em;
- border-top: solid 1px black;
+ margin-top: 0px;
}
div#cgit table.blob td.lines {
@@ -287,7 +286,7 @@ div#cgit table.blob td.linenumbers {
margin: 0; padding: 0 0.5em 0 0.5em;
vertical-align: top;
text-align: right;
- border-right: 1px solid gray;
+ color: #eee;
}
div#cgit table.blob pre {
@@ -306,20 +305,20 @@ div#cgit table.blob a.no a:hover {
div#cgit table.bin-blob {
margin-top: 0.5em;
- border: solid 1px black;
+ border: solid 1px #ccc;
}
div#cgit table.bin-blob th {
font-family: monospace;
white-space: pre;
- border: solid 1px #777;
+ border: solid 1px #ccc;
padding: 0.5em 1em;
}
div#cgit table.bin-blob td {
font-family: monospace;
white-space: pre;
- border-left: solid 1px #777;
+ border-left: solid 1px #ccc;
padding: 0em 1em;
}
diff --git a/ui-shared.c b/ui-shared.c
index 43166af..d2ffc5b 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -939,6 +939,13 @@ void cgit_print_pageheader(struct cgit_context *ctx)
html("<div class='path'>");
html("path: ");
cgit_print_path_crumbs(ctx, ctx->qry.vpath);
+ if (!strcmp(ctx->qry.page, "tree")) {
+ html(" (");
+ cgit_plain_link("plain", NULL, NULL, ctx->qry.head,
+ ctx->qry.has_sha1 ? ctx->qry.sha1 : NULL,
+ ctx->qry.vpath);
+ html(")");
+ }
html("</div>");
}
html("<div class='content'>");
diff --git a/ui-tree.c b/ui-tree.c
index b1adcc7..dd98701 100644
--- a/ui-tree.c
+++ b/ui-tree.c
@@ -104,11 +104,6 @@ static void print_object(const unsigned char *sha1, char *path, const char *base
return;
}
- htmlf("blob: %s (", sha1_to_hex(sha1));
- cgit_plain_link("plain", NULL, NULL, ctx.qry.head,
- curr_rev, path);
- html(")\n");
-
if (ctx.cfg.max_blob_size && size / 1024 > ctx.cfg.max_blob_size) {
htmlf("<div class='error'>blob size (%ldKB) exceeds display size limit (%dKB).</div>",
size / 1024, ctx.cfg.max_blob_size);
--
larsh
next prev parent reply other threads:[~2012-03-20 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 20:06 mdickie007
2012-03-20 8:08 ` larsh [this message]
2012-03-21 14:11 ` mdickie007
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120320080858.GB9012@hjemli.net \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).