From mboxrd@z Thu Jan  1 00:00:00 1970
From: larsh at hjemli.net (larsh at hjemli.net)
Date: Tue, 20 Mar 2012 08:08:58 +0000
Subject: [PATCH] Updated css to better looking blob line numbers
In-Reply-To: <4F6791D6.9050402@gmail.com>
References: <4F6791D6.9050402@gmail.com>
Message-ID: <20120320080858.GB9012@hjemli.net>

On Mon, Mar 19, 2012 at 09:06:46PM +0100, Mariusz Wojcik wrote:
> ---
>  cgit.css |   11 ++++++-----
>  1 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/cgit.css b/cgit.css
> index e06c261..1cc4921 100644
> --- a/cgit.css
> +++ b/cgit.css
> @@ -274,7 +274,7 @@ div#cgit td.ls-mode {
>   div#cgit table.blob {
>  	margin-top: 0.5em;
> -	border-top: solid 1px black;
> +	border: solid 1px #ccc;
>  }
>   div#cgit table.blob td.lines {
> @@ -287,7 +287,8 @@ div#cgit table.blob td.linenumbers {
>  	margin: 0; padding: 0 0.5em 0 0.5em;
>  	vertical-align: top;
>  	text-align: right;
> -	border-right: 1px solid gray;
> +	border-right: 1px solid #ccc;
> +	background-color: #eee;
>  }
>   div#cgit table.blob pre {
> @@ -306,20 +307,20 @@ div#cgit table.blob a.no a:hover {
>   div#cgit table.bin-blob {
>  	margin-top: 0.5em;
> -	border: solid 1px black;
> +	border: solid 1px #ccc;
>  }
>   div#cgit table.bin-blob th {
>  	font-family: monospace;
>  	white-space: pre;
> -	border: solid 1px #777;
> +	border: solid 1px #ccc;
>  	padding: 0.5em 1em;
>  }
>   div#cgit table.bin-blob td {
>  	font-family: monospace;
>  	white-space: pre;
> -	border-left: solid 1px #777;
> +	border-left: solid 1px #ccc;
>  	padding: 0em 1em;
>  }

I'd actually prefer less boxes in the cgit pages, maybe something like
this:

diff --git a/cgit.css b/cgit.css
index e06c261..0e99f61 100644
--- a/cgit.css
+++ b/cgit.css
@@ -273,8 +273,7 @@ div#cgit td.ls-mode {
 }
 
 div#cgit table.blob {
-	margin-top: 0.5em;
-	border-top: solid 1px black;
+	margin-top: 0px;
 }
 
 div#cgit table.blob td.lines {
@@ -287,7 +286,7 @@ div#cgit table.blob td.linenumbers {
 	margin: 0; padding: 0 0.5em 0 0.5em;
 	vertical-align: top;
 	text-align: right;
-	border-right: 1px solid gray;
+	color: #eee;
 }
 
 div#cgit table.blob pre {
@@ -306,20 +305,20 @@ div#cgit table.blob a.no a:hover {
 
 div#cgit table.bin-blob {
 	margin-top: 0.5em;
-	border: solid 1px black;
+	border: solid 1px #ccc;
 }
 
 div#cgit table.bin-blob th {
 	font-family: monospace;
 	white-space: pre;
-	border: solid 1px #777;
+	border: solid 1px #ccc;
 	padding: 0.5em 1em;
 }
 
 div#cgit table.bin-blob td {
 	font-family: monospace;
 	white-space: pre;
-	border-left: solid 1px #777;
+	border-left: solid 1px #ccc;
 	padding: 0em 1em;
 }
 
diff --git a/ui-shared.c b/ui-shared.c
index 43166af..d2ffc5b 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -939,6 +939,13 @@ void cgit_print_pageheader(struct cgit_context *ctx)
 		html("<div class='path'>");
 		html("path: ");
 		cgit_print_path_crumbs(ctx, ctx->qry.vpath);
+		if (!strcmp(ctx->qry.page, "tree")) {
+			html(" (");
+			cgit_plain_link("plain", NULL, NULL, ctx->qry.head,
+					ctx->qry.has_sha1 ? ctx->qry.sha1 : NULL,
+					ctx->qry.vpath);
+			html(")");
+		}
 		html("</div>");
 	}
 	html("<div class='content'>");
diff --git a/ui-tree.c b/ui-tree.c
index b1adcc7..dd98701 100644
--- a/ui-tree.c
+++ b/ui-tree.c
@@ -104,11 +104,6 @@ static void print_object(const unsigned char *sha1, char *path, const char *base
 		return;
 	}
 
-	htmlf("blob: %s (", sha1_to_hex(sha1));
-	cgit_plain_link("plain", NULL, NULL, ctx.qry.head,
-		        curr_rev, path);
-	html(")\n");
-
 	if (ctx.cfg.max_blob_size && size / 1024 > ctx.cfg.max_blob_size) {
 		htmlf("<div class='error'>blob size (%ldKB) exceeds display size limit (%dKB).</div>",
 				size / 1024, ctx.cfg.max_blob_size);
--
larsh