From mboxrd@z Thu Jan  1 00:00:00 1970
From: valentin.haenel at gmx.de (Valentin Haenel)
Date: Mon, 29 Oct 2012 16:50:13 +0100
Subject: [PATCHv2 1/3] Add config option user-envvar
In-Reply-To: <20121029145341.GB31761@sir-slippy>
References: <1350378927-10834-1-git-send-email-valentin.haenel@gmx.de>
 <1350894558-24840-1-git-send-email-valentin.haenel@gmx.de>
 <k6i03c$mp0$1@ger.gmane.org>
 <20121029092218.GA17370@kudu.in-berlin.de>
 <20121029145341.GB31761@sir-slippy>
Message-ID: <20121029155013.GB8463@kudu.in-berlin.de>

* Ben Boeckel <mathstuf at gmail.com> [2012-10-29]:
> On Mon, Oct 29, 2012 at 10:22:18 +0100, Valentin Haenel wrote:
> > * Ben Boeckel <mathstuf at gmail.com> [2012-10-28]:
> > > On Mon, Oct 22, 2012 at 08:29:16 GMT, Valentin Haenel wrote:
> > > > @@ -166,6 +166,7 @@ struct cgit_query {
> > > >  
> > > >  struct cgit_config {
> > > >  	char *agefile;
> > > > +	char *user_envvar;
> > > 
> > > It should be free'd where the rest of these are free'd. I don't see that
> > > here.
> > > 
> > > >  	char *cache_root;
> > > >  	char *clone_prefix;
> > > >  	char *clone_url;
> > > > @@ -263,6 +264,7 @@ struct cgit_environment {
> > > >  	char *script_name;
> > > >  	char *server_name;
> > > >  	char *server_port;
> > > > +	char *remote_user;
> > > 
> > > Same here.
> > 
> > Forgive me if I am mistaken, but I don't see any of those free'd
> > anywhere.
> 
> Hrm. That's...unfortunate. But likely a different patch if it's missing
> altogether.

I think the reasoning is: it's a CGI, so it gets called for every request
and then exits. So maybe, there is no need to free anything, because the
program is short lived?

V-