From: plenz at cis.fu-berlin.de (Julius Plenz)
Subject: [PATCH 2/2] bugfix: make ss-diff correctly handle tab expansion
Date: Tue, 30 Oct 2012 18:12:57 +0100 [thread overview]
Message-ID: <20121030171257.GC378591@plenz.com> (raw)
In-Reply-To: <CAHmME9pi8jJtKy+8nZ83+0DqLkZM1Ei-pJS=p7V3NG-P8X310A@mail.gmail.com>
* Jason A. Donenfeld <Jason at zx2c4.com> [2012-10-30 17:58]:
> Doing it this way, you don't have to hard code the initial space,
> since m % n < n.
Not really true. If you are in the 8th column (i.e., there are 8
characters on the line), you need a tab to be 8 spaces wide.
Otherwise, a tab should pad to the next multiple of 8.
So it's rather: len % 8 == 0 ? 8 : (8 - len % 8)
Julius
next prev parent reply other threads:[~2012-10-30 17:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 12:56 [PATCH 0/2] side-by-side-diff fixes plenz
2012-10-30 12:56 ` [PATCH 1/2] bugfix: in ssdiff, fix line number links plenz
2012-10-30 16:37 ` Jason
2012-10-30 12:56 ` [PATCH 2/2] bugfix: make ss-diff correctly handle tab expansion plenz
2012-10-30 14:56 ` plenz
2012-10-30 16:56 ` Jason
2012-10-30 17:12 ` plenz [this message]
2012-10-30 17:25 ` Jason
2012-10-30 17:52 ` plenz
2012-11-15 0:03 ` Jason
2012-11-15 16:35 ` [PATCH v2] " plenz
2013-02-01 12:51 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121030171257.GC378591@plenz.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).