From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: [PATCH v3 3/4] cgit.mk: don't rebuild everything if CGIT_VERSION changes
Date: Thu, 7 Mar 2013 09:16:50 +0100 [thread overview]
Message-ID: <20130307081650.GA25901@blizzard> (raw)
In-Reply-To: <513849BF.7010201@necoro.eu>
On Thu, Mar 07, 2013 at 09:03:11AM +0100, Ren? Neumann wrote:
> > +# Only cgit.c reference CGIT_VERSION so we only rebuild its objects when the
> > +# version changes.
> > +CGIT_VERSION_OBJS := $(addprefix $(CGIT_PREFIX),cgit.o)
> > +$(CGIT_VERSION_OBJS): $(CGIT_PREFIX)VERSION
> > +$(CGIT_VERSION_OBJS): EXTRA_CPPFLAGS = \
> > + -DCGIT_VERSION='"$(CGIT_VERSION)"'
>
> Is the small gain (not rebuilding a couple of small C-files) worth this
> hassle? Because it sounds a bit like a maintenance nightmare: One more
> place to remember to put a file.
>
> If cgit were some template-C++-monster, this might be useful, but cgit
> is not...
I don't think any other file should reference CGIT_VERSION in the
future, see patch 2/4 in this patch set.
>
> - Ren?
>
>
> _______________________________________________
> cgit mailing list
> cgit at hjemli.net
> http://hjemli.net/mailman/listinfo/cgit
next prev parent reply other threads:[~2013-03-07 8:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 21:22 [PATCH v3 0/4] Makefile improvements john
2013-03-06 21:22 ` [PATCH v3 1/4] Makefile: re-use Git's Makefile where possible john
2013-03-20 19:33 ` Jason
2013-03-06 21:22 ` [PATCH v3 2/4] ui-patch: use cgit_version not CGIT_VERSION john
2013-03-06 21:22 ` [PATCH v3 3/4] cgit.mk: don't rebuild everything if CGIT_VERSION changes john
2013-03-07 8:03 `
2013-03-07 8:16 ` cgit [this message]
2013-03-07 9:07 ` john
2013-03-07 9:49 `
2013-03-06 21:22 ` [PATCH v3 4/4] cgit.mk: Use SHELL_PATH_SQ to run gen-version.sh john
2013-03-20 19:34 ` [PATCH v3 0/4] Makefile improvements Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130307081650.GA25901@blizzard \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).