From mboxrd@z Thu Jan  1 00:00:00 1970
From: cgit at cryptocrack.de (Lukas Fleischer)
Date: Thu, 7 Mar 2013 09:16:50 +0100
Subject: [PATCH v3 3/4] cgit.mk: don't rebuild everything if CGIT_VERSION
 changes
In-Reply-To: <513849BF.7010201@necoro.eu>
References: <cover.1362603173.git.john@keeping.me.uk>
 <4ec4a0198520151693229087a52b064e59b6567c.1362603173.git.john@keeping.me.uk>
 <513849BF.7010201@necoro.eu>
Message-ID: <20130307081650.GA25901@blizzard>

On Thu, Mar 07, 2013 at 09:03:11AM +0100, Ren? Neumann wrote:
> > +# Only cgit.c reference CGIT_VERSION so we only rebuild its objects when the
> > +# version changes.
> > +CGIT_VERSION_OBJS := $(addprefix $(CGIT_PREFIX),cgit.o)
> > +$(CGIT_VERSION_OBJS): $(CGIT_PREFIX)VERSION
> > +$(CGIT_VERSION_OBJS): EXTRA_CPPFLAGS = \
> > +	-DCGIT_VERSION='"$(CGIT_VERSION)"'
> 
> Is the small gain (not rebuilding a couple of small C-files) worth this
> hassle? Because it sounds a bit like a maintenance nightmare: One more
> place to remember to put a file.
> 
> If cgit were some template-C++-monster, this might be useful, but cgit
> is not...

I don't think any other file should reference CGIT_VERSION in the
future, see patch 2/4 in this patch set.

> 
> - Ren?
> 
> 
> _______________________________________________
> cgit mailing list
> cgit at hjemli.net
> http://hjemli.net/mailman/listinfo/cgit