From: john at keeping.me.uk (John Keeping)
Subject: [PATCH v2] html.c: Replace strdup() with xstrdup()
Date: Sat, 6 Apr 2013 12:14:22 +0100 [thread overview]
Message-ID: <20130406111422.GS2222@serenity.lan> (raw)
In-Reply-To: <20130406105011.GA2149@blizzard>
On Sat, Apr 06, 2013 at 12:50:11PM +0200, Lukas Fleischer wrote:
> On Sat, Apr 06, 2013 at 10:44:10AM +0100, John Keeping wrote:
> > On Sat, Apr 06, 2013 at 11:17:12AM +0200, Lukas Fleischer wrote:
> > > Use the xstrdup() wrapper which already bails out if strdup() returns a
> > > NULL pointer.
> > >
> > > Signed-off-by: Lukas Fleischer <cgit at cryptocrack.de>
> > > ---
> > > Forgot to add the git-compat-util header.
> > >
> > > html.c | 7 ++-----
> > > 1 file changed, 2 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/html.c b/html.c
> > > index d60a41f..705b710 100644
> > > --- a/html.c
> > > +++ b/html.c
> > > @@ -12,6 +12,7 @@
> > > #include <stdarg.h>
> > > #include <string.h>
> > > #include <errno.h>
> > > +#include <git-compat-util.h>
> >
> > git-compat-util.h should be included before any other headers, since it
> > may #define variables that affect how those headers behave.
>
> Good catch. On second thought, shouldn't we rather include "cgit.h" like
> it is done in all other source files?
Yes, that's probably better.
> >
> > > /* Percent-encoding of each character, except: a-zA-Z0-9!$()*,./:;@- */
> > > static const char* url_escape_table[256] = {
> > > @@ -306,11 +307,7 @@ int http_parse_querystring(const char *txt_, void (*fn)(const char *name, const
> > > if (!txt_)
> > > return 0;
> > >
> > > - o = t = txt = strdup(txt_);
> > > - if (t == NULL) {
> > > - printf("Out of memory\n");
> > > - exit(1);
> > > - }
> > > + o = t = txt = xstrdup(txt_);
> > > while ((c=*t) != '\0') {
> > > if (c == '=') {
> > > *t = '\0';
> > > --
> > > 1.8.2.674.g2c8b7bf
next prev parent reply other threads:[~2013-04-06 11:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 9:11 [PATCH] " cgit
2013-04-06 9:17 ` [PATCH v2] " cgit
2013-04-06 9:44 ` john
2013-04-06 10:50 ` cgit
2013-04-06 11:14 ` john [this message]
2013-04-06 11:30 ` [PATCH v3] " cgit
2013-04-06 14:26 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130406111422.GS2222@serenity.lan \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).