From mboxrd@z Thu Jan  1 00:00:00 1970
From: john at keeping.me.uk (John Keeping)
Date: Sun, 7 Apr 2013 16:43:26 +0100
Subject: [PATCH v2 22/22] ui-shared.c: use struct strbuf instead of fmt()
In-Reply-To: <CAHmME9q+6i7QpH8jDBvi9VJ6cPVe1j0hhAfhox2uQ6SDLe1cmA@mail.gmail.com>
References: <cover.1365326321.git.john@keeping.me.uk>
 <cover.1365344206.git.john@keeping.me.uk>
 <3a54052ecfc01a0d7da4258d731d0ca9eca6ef50.1365344206.git.john@keeping.me.uk>
 <CAHmME9q+6i7QpH8jDBvi9VJ6cPVe1j0hhAfhox2uQ6SDLe1cmA@mail.gmail.com>
Message-ID: <20130407154326.GF2222@serenity.lan>

On Sun, Apr 07, 2013 at 05:21:28PM +0200, Jason A. Donenfeld wrote:
> On Sun, Apr 7, 2013 at 4:26 PM, John Keeping <john at keeping.me.uk> wrote:
> >  const char *cgit_hosturl()
> >  {
> > +       struct strbuf sb = STRBUF_INIT;
> 
> This is now unused.

Thanks.  Fixed and pushed to my GitHub repository [1].  I'll avoid
sending another reroll of the entire series and only send incremental
patches here if nothing serious is found.

[1] http://github.com/johnkeeping/cgit

> >         if (ctx.env.http_host)
> >                 return ctx.env.http_host;
> >         if (!ctx.env.server_name)
> >                 return NULL;
> >         if (!ctx.env.server_port || atoi(ctx.env.server_port) == 80)
> >                 return ctx.env.server_name;
> > -       return xstrdup(fmt("%s:%s", ctx.env.server_name, ctx.env.server_port));
> > +       return fmtalloc("%s:%s", ctx.env.server_name, ctx.env.server_port);
> >  }