List for cgit developers and users
 help / color / mirror / Atom feed
From: john at keeping.me.uk (John Keeping)
Subject: [PATCH] Update git to v1.8.2.1
Date: Mon, 8 Apr 2013 19:47:44 +0100	[thread overview]
Message-ID: <20130408184743.GY2222@serenity.lan> (raw)
In-Reply-To: <51630E8E.2090508@hupie.com>

On Mon, Apr 08, 2013 at 08:38:06PM +0200, Ferry Huberts wrote:
> > I think you're being bitten by Git's default configuration (assuming
> > that you built as root, or at least with $HOME set to /root), which
> > looks like this:
> > 
> >     prefix = $(HOME)
> >     bindir_relative = bin
> >     bindir = $(prefix)/$(bindir_relative)
> >     mandir = share/man
> >     infodir = share/info
> >     gitexecdir = libexec/git-core
> >     mergetoolsdir = $(gitexecdir)/mergetools
> >     sharedir = $(prefix)/share
> >     gitwebdir = $(sharedir)/gitweb
> >     localedir = $(sharedir)/locale
> >     template_dir = share/git-core/templates
> >     htmldir = share/doc/git-doc
> >     ETC_GITCONFIG = $(sysconfdir)/gitconfig
> >     ETC_GITATTRIBUTES = $(sysconfdir)/gitattributes
> > 
> > You may need to create a "config.mak" inside the "git" subdirectory of
> > your CGit clone and add the line:
> > 
> >     prefix = /usr
> 
> 
> ok that seems to work.
> Adjusting my deploy script.
> 
> 
> This indicates to me that there is a bug somewhere.
> A permission denied should not crash cgit. It should treat that as 'file
> not there', the same as with the config.mak hack.

There was a change in Git to promote permission denied from a silent
failure to a warning (IIRC).  I'm surprised that this causes CGit to
exit but I haven't followed that code carefully.




  parent reply	other threads:[~2013-04-08 18:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08  8:00 john
2013-04-08  8:42 ` mailings
2013-04-08 13:41 ` Jason
2013-04-08 18:12 ` mailings
2013-04-08 18:16   ` mailings
2013-04-08 18:25     ` cgit
2013-04-08 18:31       ` Jason
2013-04-08 18:30     ` john
2013-04-08 18:37       ` Jason
2013-04-08 18:22   ` john
2013-04-08 18:38     ` mailings
2013-04-08 18:39       ` Jason
2013-04-08 18:42         ` mailings
2013-04-08 18:43       ` 
2013-04-08 18:47       ` john [this message]
2013-04-08 18:48         ` Jason
2013-04-08 18:52           ` [PATCH] Do not load system gitconfig and gitattributes john
2013-04-08 18:55             ` Jason
2013-04-08 19:00               ` mailings
2013-04-08 19:02                 ` Jason
2013-04-08 19:15                   ` Jason
2013-04-08 19:24                     ` john
2013-04-08 19:29                       ` Jason
2013-04-08 19:28                     ` mailings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130408184743.GY2222@serenity.lan \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).