From: john at keeping.me.uk (John Keeping)
Subject: [PATCH 2/3] t0107: Skip ZIP tests if unzip(1) isn't available
Date: Mon, 8 Apr 2013 19:49:17 +0100 [thread overview]
Message-ID: <20130408184917.GZ2222@serenity.lan> (raw)
In-Reply-To: <20130408184714.GA8137@blizzard>
On Mon, Apr 08, 2013 at 08:47:14PM +0200, Lukas Fleischer wrote:
> On Mon, Apr 08, 2013 at 07:26:32PM +0100, John Keeping wrote:
> > On Mon, Apr 08, 2013 at 08:18:19PM +0200, Lukas Fleischer wrote:
> > > Skip tests using unzip(1) if the binary isn't available instead of
> > > erroring out.
> > >
> > > Signed-off-by: Lukas Fleischer <cgit at cryptocrack.de>
> > > ---
> > > tests/t0107-snapshot.sh | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/tests/t0107-snapshot.sh b/tests/t0107-snapshot.sh
> > > index 132d2e9..14ea62d 100755
> > > --- a/tests/t0107-snapshot.sh
> > > +++ b/tests/t0107-snapshot.sh
> > > @@ -55,6 +55,13 @@ run_test 'strip off the header lines (zip)' '
> > > tail -n +6 trash/tmp >trash/master.zip
> > > '
> > >
> > > +unzip=`which unzip`
> > > +test -n "$unzip" || {
> > > + echo "Skipping tests: unzip not found"
> > > + tests_done
> >
> > Is this based on the jk/use-git-test-suite? If so can we use skip_all
> > and test_done instead of tests_done?
> >
> > I have a WIP series that does the global replacements of
> > s/tests_done/test_done/ and s/run_test/test_expect_success/.
>
> It would be great if you could submit that patch and merge into
> jk/use-git-test-suite first, so that we won't get a conflict...
I was hanging onto it to avoid sending lots of incremental patches on
top because I keep thinking of new things to change :-)
But I'll send it out shortly after giving it a quick review.
next prev parent reply other threads:[~2013-04-08 18:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 18:18 [PATCH 1/3] tests/: Do not use `sed -i` cgit
2013-04-08 18:18 ` [PATCH 2/3] t0107: Skip ZIP tests if unzip(1) isn't available cgit
2013-04-08 18:26 ` john
2013-04-08 18:41 ` Jason
2013-04-08 18:47 ` cgit
2013-04-08 18:49 ` john [this message]
2013-04-08 22:19 ` Jason
2013-04-08 22:23 ` john
2013-04-08 20:57 ` Jason
2013-04-08 18:18 ` [PATCH 3/3] t0107: Use `tar -z` for gzip'ed archives cgit
2013-04-08 22:15 ` Jason
2013-04-08 18:24 ` [PATCH 1/3] tests/: Do not use `sed -i` john
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130408184917.GZ2222@serenity.lan \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).