List for cgit developers and users
 help / color / mirror / Atom feed
From: john at keeping.me.uk (John Keeping)
Subject: [PATCH] tests: Make sure that git does not access $HOME
Date: Mon, 8 Apr 2013 21:38:17 +0100	[thread overview]
Message-ID: <20130408203816.GE2222@serenity.lan> (raw)
In-Reply-To: <CAHmME9rZ3eXLSTkhy3XyBzAHzUuOhBuEdFAXGng34rAsKVODLg@mail.gmail.com>

On Mon, Apr 08, 2013 at 10:35:09PM +0200, Jason A. Donenfeld wrote:
> On Mon, Apr 8, 2013 at 10:32 PM, John Keeping <john at keeping.me.uk> wrote:
> > Can we avoid a pipe here and use a temporary file instead?
> 
> Sure, no problem. Why do you prefer a temporary file over a pipe?

The pipe hides the exit status of whatever is on its LHS, so if
cgit/strace crashes or exits with an error, piping the output completely
loses that, which is particularly bad if we're then grep'ing for a
negative.




      reply	other threads:[~2013-04-08 20:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08 20:20 Jason
2013-04-08 20:22 ` Jason
2013-04-08 20:32 ` john
2013-04-08 20:35   ` Jason
2013-04-08 20:38     ` john [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130408203816.GE2222@serenity.lan \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).