From: john at keeping.me.uk (John Keeping)
Subject: [PATCH] Regression fix: Make section-from-path=-1 work again
Date: Tue, 16 Apr 2013 15:30:09 +0100 [thread overview]
Message-ID: <20130416143008.GM2278@serenity.lan> (raw)
In-Reply-To: <1366121446-970028-1-git-send-email-plenz@cis.fu-berlin.de>
On Tue, Apr 16, 2013 at 04:10:46PM +0200, Julius Plenz wrote:
> This fixes a regression introduced in commit fb3655df, "use struct
> strbuf instead of static buffers":
>
> > The pattern there is to append the filename, use it and then reset
> > the buffer to its original length (retaining a trailing '/').
>
> This makes the "count slashes from end of string" fail. My workaround is
> to start counting only before the trailing slash.
This is the "rel" buffer, not "path" so I think it would be better to
just strip any trailing slash from "rel" when it is assigned. This has
the benefit of also making sure we don't have a trailing '/' in the
section name.
What do you think?
next prev parent reply other threads:[~2013-04-16 14:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 14:10 plenz
2013-04-16 14:30 ` john [this message]
2013-04-16 14:50 ` plenz
2013-04-16 17:39 ` john
2013-04-17 11:38 ` plenz
2013-04-17 11:41 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130416143008.GM2278@serenity.lan \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).