List for cgit developers and users
 help / color / mirror / Atom feed
From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: [PATCH] configfile: Use git's internal config system instead.
Date: Tue, 4 Jun 2013 20:52:02 +0200	[thread overview]
Message-ID: <20130604185202.GA29937@blizzard> (raw)
In-Reply-To: <1370368728-27214-1-git-send-email-Jason@zx2c4.com>

On Tue, Jun 04, 2013 at 07:58:48PM +0200, Jason A. Donenfeld wrote:
> This commit is completely broken and does not work but here's the
> general idea if someone would like to clean it up and work out the
> details.
> ---
>  cgit.c       | 12 +++++----
>  cgit.mk      |  1 -
>  configfile.c | 87 ------------------------------------------------------------
>  configfile.h |  8 ------
>  scan-tree.c  |  7 ++---
>  5 files changed, 11 insertions(+), 104 deletions(-)
>  delete mode 100644 configfile.c
>  delete mode 100644 configfile.h
> 
> [...]
> +		git_config_from_file(config_cb, expand_macros(value), NULL);

git_config_from_file() does not allow dots (".") inside configuration
variable names (since they are used to delimit sections from keys). If
we want to use the Git configuration system like this, we have to change
our configuration file format to use sections ("[repo]") instead of
prefixing each variable ("repo.").


  reply	other threads:[~2013-06-04 18:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-04 17:58 Jason
2013-06-04 18:52 ` cgit [this message]
2013-08-12 18:35   ` Jason
2013-08-12 19:18     ` mackyle
  -- strict thread matches above, loose matches on Subject: below --
2013-06-04 17:48 Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130604185202.GA29937@blizzard \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).