From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: RFE: download patch between arbitrary revisions
Date: Sun, 16 Jun 2013 09:56:55 +0200 [thread overview]
Message-ID: <20130616075655.GA27832@blizzard> (raw)
In-Reply-To: <20130613222126.GC23890@serenity.lan>
On Thu, Jun 13, 2013 at 11:21:26PM +0100, John Keeping wrote:
> On Thu, Jun 13, 2013 at 11:58:10PM +0200, Lukas Fleischer wrote:
> > On Mon, Jun 03, 2013 at 07:49:53PM +0100, John Keeping wrote:
> > > On Sun, Jun 02, 2013 at 09:19:11PM -0400, Konstantin Ryabitsev wrote:
> > > > There is currently a way to render a diff between two arbitrary objects,
> > > > e.g.:
> > > >
> > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/diff/?id=v3.10-rc4&id2=v3.10-rc3
> > > >
> > > > However, there doesn't appear to be a way to download a patch in the
> > > > same way -- it will only make patch against id's parent. E.g.:
> > > >
> > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=v3.10-rc4&id2=v3.10-rc3
> > > >
> > > > Any way we can make the behaviour of patch match that of diff?
> > >
> [...]
>
> So:
>
> /patch/?id=v1.8.3.1&id2=v1.8.3
>
> generates something like "git format-patch v1.8.3..v1.8.3.1". And
>
> /rawdiff/?id=v1.8.3.1&id2=v1.8.3
>
> generates the diff with no HTML around it.
>
> The latter could be a query parameter instead ("raw=1"?). Having not
> investigated the impact on the code, I have no preference for one over
> the other.
Sounds good to me either way. Jason?
Also, I just wondered whether this could be used to DoS servers when
requesting a series of patches for a huge range of revisions... Maybe
there should be some kind of limit?
next prev parent reply other threads:[~2013-06-16 7:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 1:19 mricon
2013-06-03 18:49 ` john
2013-06-13 21:58 ` cgit
2013-06-13 22:21 ` john
2013-06-16 7:56 ` cgit [this message]
2013-06-16 10:11 ` john
2013-06-16 19:18 ` cgit
2013-08-06 19:23 ` mricon
2013-08-06 21:40 ` cgit
2013-08-12 19:05 ` Jason
2013-08-14 8:56 ` cgit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130616075655.GA27832@blizzard \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).