From mboxrd@z Thu Jan  1 00:00:00 1970
From: john at keeping.me.uk (John Keeping)
Date: Wed, 14 Aug 2013 22:47:54 +0100
Subject: [PATCH 0/3] Download patch between arbitrary revisions
In-Reply-To: <1376470233-28581-1-git-send-email-cgit@cryptocrack.de>
References: <1376470233-28581-1-git-send-email-cgit@cryptocrack.de>
Message-ID: <20130814214753.GL2337@serenity.lan>

On Wed, Aug 14, 2013 at 10:50:30AM +0200, Lukas Fleischer wrote:
> This is the first small patch series that allows for generating raw
> patches between arbitrary revisions.
> 
> Note that the first patch only does some refactoring that is required in
> preparation for the second one. I wanted to do the same refactoring for
> the corresponding functions in ui-diff.c but this turned out to be much
> harder due to the use of global variables. It would be nice to do the
> same refactoring with filepair_cb() from ui-diff.c and eventually merge
> both filepair_cb(), header() and print_line() functions since they share
> quite some code. This is out of the scope of this patch series, though.
> 
> Lukas Fleischer (3):
>   Extract filepair_cb from ui-patch.c
>   Allow for creating raw diffs with cgit_print_diff()
>   cmd.c: Add a "rawdiff" command
> 
>  cmd.c       |  8 ++++++-
>  ui-commit.c |  2 +-
>  ui-diff.c   | 10 ++++++++-
>  ui-diff.h   |  2 +-
>  ui-patch.c  | 74 +------------------------------------------------------------
>  ui-shared.c | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  ui-shared.h |  1 +
>  7 files changed, 92 insertions(+), 77 deletions(-)

Nicely done!  FWIW, the whole series

Reviewed-by: John Keeping <john at keeping.me.uk>

However, it would be nice to see something touching tests/ since we do
currently make some effort to test the basics of each command.