From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: [PATCH/RFC 1/2] ui-diff: Use diff_tree_sha1() for raw diff formatting
Date: Tue, 27 Aug 2013 03:37:37 +0200 [thread overview]
Message-ID: <20130827013737.GB5933@blizzard> (raw)
In-Reply-To: <CAHmME9rFZPuV5BWh156Xdbe24fWLUEjGdcXhySLFtb0PGwrsCQ@mail.gmail.com>
On Tue, Aug 27, 2013 at 03:31:14AM +0200, Jason A. Donenfeld wrote:
>
>
>
> On Tue, Aug 27, 2013 at 3:27 AM, Lukas Fleischer <cgit at cryptocrack.de> wrote:
>
> + } else {
> + /*
> + * SHA-1 of an empty tree. We might be better off
> not
> + * hardcoding this.
> + */
> + get_sha1
> ("4b825dc642cb6eb9a060e54bf8d69288fbee4904",
> + old_tree_sha1);
> + }
> +
>
>
> What's the story here?
This is needed if we want to build a diff for the root commit. It
doesn't have any parent, so we need to build against the empty tree. I
am pretty sure there are better ways to do this -- just too tired to
check now (hence the "RFC" in the subject).
prev parent reply other threads:[~2013-08-27 1:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 1:27 cgit
2013-08-27 1:27 ` [PATCH 2/2] ui-shared: Drop filepair_cb_raw() and helper cgit
2013-08-27 1:31 ` [PATCH/RFC 1/2] ui-diff: Use diff_tree_sha1() for raw diff formatting Jason
2013-08-27 1:37 ` cgit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827013737.GB5933@blizzard \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).