* [PATCH 2/5] Fix about-formatting.sh
@ 2013-10-08 14:06 martinerikwerner
0 siblings, 0 replies; 3+ messages in thread
From: martinerikwerner @ 2013-10-08 14:06 UTC (permalink / raw)
> dash failed to parse the script.
>
> Signed-off-by: P?emysl Janouch <p.janouch at gmail.com>
> ---
> filters/about-formatting.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/filters/about-formatting.sh b/filters/about-formatting.sh
> index 313a4e6..892fbeb 100755
> --- a/filters/about-formatting.sh
> +++ b/filters/about-formatting.sh
> @@ -18,7 +18,7 @@
> # CGIT_REPO_CLONE_URL ( = repo.clone-url setting )
>
> cd "$(dirname $0)/html-converters/"
> -case "$(tr '[:upper:]' '[:lower:]' <<<"$1")" in
> +case "$(printf '%s' "$1" | tr '[:upper:]' '[:lower:]')" in
> *.md|*.mkd) exec ./md2html; ;;
> *.rst) exec ./rst2html; ;;
> *.[1-9]) exec ./man2html; ;;
> --
> 1.7.10.4
I'd like to second this patch, I was somewhat pulling my hair trying to figure
out why it was treating html as txt until I noticed that it was simply down to
a bashism in an sh script.
--
Martin Erik Werner <martinerikwerner at gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/5] Fix about-formatting.sh
2013-09-11 18:10 ` [PATCH 2/5] Fix about-formatting.sh
@ 2014-01-08 15:47 ` Jason
0 siblings, 0 replies; 3+ messages in thread
From: Jason @ 2014-01-08 15:47 UTC (permalink / raw)
Merged. Good catch.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/5] Fix about-formatting.sh
2013-09-11 18:10 [PATCH 0/5] Miscellaneous fixes
@ 2013-09-11 18:10 `
2014-01-08 15:47 ` Jason
0 siblings, 1 reply; 3+ messages in thread
From: @ 2013-09-11 18:10 UTC (permalink / raw)
dash failed to parse the script.
Signed-off-by: P?emysl Janouch <p.janouch at gmail.com>
---
filters/about-formatting.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/filters/about-formatting.sh b/filters/about-formatting.sh
index 313a4e6..892fbeb 100755
--- a/filters/about-formatting.sh
+++ b/filters/about-formatting.sh
@@ -18,7 +18,7 @@
# CGIT_REPO_CLONE_URL ( = repo.clone-url setting )
cd "$(dirname $0)/html-converters/"
-case "$(tr '[:upper:]' '[:lower:]' <<<"$1")" in
+case "$(printf '%s' "$1" | tr '[:upper:]' '[:lower:]')" in
*.md|*.mkd) exec ./md2html; ;;
*.rst) exec ./rst2html; ;;
*.[1-9]) exec ./man2html; ;;
--
1.7.10.4
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-08 15:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-08 14:06 [PATCH 2/5] Fix about-formatting.sh martinerikwerner
-- strict thread matches above, loose matches on Subject: below --
2013-09-11 18:10 [PATCH 0/5] Miscellaneous fixes
2013-09-11 18:10 ` [PATCH 2/5] Fix about-formatting.sh
2014-01-08 15:47 ` Jason
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).