[PATCH 2/5] Fix about-formatting.sh

[PATCH 2/5] Fix about-formatting.sh

[martinerikwerner]

> dash failed to parse the script.
>
> Signed-off-by: P?emysl Janouch <p.janouch at gmail.com>
> ---
>  filters/about-formatting.sh |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/filters/about-formatting.sh b/filters/about-formatting.sh
> index 313a4e6..892fbeb 100755
> --- a/filters/about-formatting.sh
> +++ b/filters/about-formatting.sh
> @@ -18,7 +18,7 @@
>  # CGIT_REPO_CLONE_URL  ( = repo.clone-url setting )
>  
>  cd "$(dirname $0)/html-converters/"
> -case "$(tr '[:upper:]' '[:lower:]' <<<"$1")" in
> +case "$(printf '%s' "$1" | tr '[:upper:]' '[:lower:]')" in
>  	*.md|*.mkd) exec ./md2html; ;;
>  	*.rst) exec ./rst2html; ;;
>  	*.[1-9]) exec ./man2html; ;;
> -- 
> 1.7.10.4

I'd like to second this patch, I was somewhat pulling my hair trying to figure
out why it was treating html as txt until I noticed that it was simply down to
a bashism in an sh script.

--
Martin Erik Werner <martinerikwerner at gmail.com>

[PATCH 0/5] Miscellaneous fixes

[@ 2013-09-11 18:10 UTC (permalink / raw)]

Hi there. This patchset of tiny, mutually independent changes is meant
to solve a few problems that I've experienced while configuring cgit on
my Ubuntu machine.

P?emysl Janouch (5):
  Fix some spelling errors
  Fix about-formatting.sh
  Fix UTF-8 with syntax-highlighting.py
  Fix the example configuration
  Add a suggestion to the manpage

 cgitrc.5.txt                   |   17 +++++++++--------
 filters/about-formatting.sh    |    2 +-
 filters/syntax-highlighting.py |    1 +
 3 files changed, 11 insertions(+), 9 deletions(-)

-- 
1.7.10.4

[PATCH 2/5] Fix about-formatting.sh

[@ 2013-09-11 18:10 UTC (permalink / raw)]

dash failed to parse the script.

Signed-off-by: P?emysl Janouch <p.janouch at gmail.com>
---
 filters/about-formatting.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/filters/about-formatting.sh b/filters/about-formatting.sh
index 313a4e6..892fbeb 100755
--- a/filters/about-formatting.sh
+++ b/filters/about-formatting.sh
@@ -18,7 +18,7 @@
 # CGIT_REPO_CLONE_URL  ( = repo.clone-url setting )
 
 cd "$(dirname $0)/html-converters/"
-case "$(tr '[:upper:]' '[:lower:]' <<<"$1")" in
+case "$(printf '%s' "$1" | tr '[:upper:]' '[:lower:]')" in
 	*.md|*.mkd) exec ./md2html; ;;
 	*.rst) exec ./rst2html; ;;
 	*.[1-9]) exec ./man2html; ;;
-- 
1.7.10.4

[PATCH 2/5] Fix about-formatting.sh

[Jason]

Merged. Good catch.