List for cgit developers and users
 help / color / mirror / Atom feed
From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: RFE: author/committer/tagger links (enable cgit to show gravatar for author, committer and tagger)
Date: Thu, 09 Jan 2014 20:34:27 +0100	[thread overview]
Message-ID: <20140109193427.708.81013@typhoon.lan> (raw)
In-Reply-To: <20140109192304.GK7608@serenity.lan>

On Thu, 09 Jan 2014 at 20:23:04, John Keeping wrote:
> [...]
> Presumably this would just pass the "A. U. Thor <author at example.com>"
> string to the filter and we could just map that to the output.
> [...]
> We could take an incremental approach like git-check-attr and friends do
> when GIT_FLUSH=1, but I'm not sure how well we could delimit the output
> in that case - I doubt a single line would be sufficient for all cases.
> If we're not careful that approach could end up with capability flags
> and other complex things like the fast-import protocol.

These ideas sound good to me -- much better than the initial Gravatar
approach -- presumed they can be implemented efficiently. In case the
choice of a delimiter becomes a problem, we could add another option to
switch between newline ("\n") and null character ("\0"), or even allow
for specifying a custom delimiter.

> 
> My gut feeling is that it /should/ be OK because CGit's caching layer
> means that we don't actually regenerate pages too often and CGit tends
> to be blazingly fast anyway, but it would be interesting to see some
> benchmarks of how much overhead a call to "true" adds.

Agreed.


  reply	other threads:[~2014-01-09 19:34 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-08 14:34 Welcome on board Lukas Fleischer Jason
2014-01-08 14:53 ` [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger mail
2014-01-08 15:12   ` Jason
2014-01-08 15:23     ` [PATCH " mail
2014-01-08 15:56       ` Jason
2014-01-09  8:52         ` mail
2014-01-09 15:13           ` Jason
2014-01-08 16:00       ` Jason
2014-01-09  9:13         ` mail
2014-01-08 15:36     ` [RESEND PATCH " mathstuf
2014-01-08 17:15     ` normalperson
2014-01-08 17:29       ` Jason
2014-01-08 18:35         ` stefan
2014-01-09  9:18         ` list
2014-01-09 15:19           ` Jason
2014-01-13 14:18             ` list
2014-01-13 14:24               ` Jason
2014-01-14 17:22                 ` list
2014-01-14 17:23                   ` Jason
2014-01-14 17:35                     ` list
2014-01-14 17:45                       ` 
2014-01-14 17:51                       ` Jason
2014-01-14 17:58                         ` list
2014-01-14 18:00                           ` Jason
2014-01-09 15:21         ` RFE: author/committer/tagger links (enable cgit to show gravatar for author, committer and tagger) mricon
2014-01-09 17:50           ` Jason
2014-01-09 18:07             ` john
2014-01-09 18:59               ` Jason
2014-01-09 19:23                 ` john
2014-01-09 19:34                   ` cgit [this message]
2014-01-09 19:38 ` Welcome on board Lukas Fleischer info

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140109193427.708.81013@typhoon.lan \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).