From: john at keeping.me.uk (John Keeping)
Subject: [PATCH 2/2] README: Update dependencies
Date: Thu, 9 Jan 2014 20:10:35 +0000 [thread overview]
Message-ID: <20140109201035.GL7608@serenity.lan> (raw)
In-Reply-To: <20140109192624.708.49862@typhoon.lan>
On Thu, Jan 09, 2014 at 08:26:24PM +0100, Lukas Fleischer wrote:
> On Thu, 09 Jan 2014 at 19:01:42, John Keeping wrote:
> > On Thu, Jan 09, 2014 at 04:13:08PM +0100, Jason A. Donenfeld wrote:
> > > On Thu, Jan 9, 2014 at 8:30 AM, Lukas Fleischer <cgit at cryptocrack.de> wrote:
> > > > We depend on Git in the test suite. Maybe this should be changed to use
> > > > the binary from the Git submodule instead?
> > >
> > > I think we discussed the possibility of this a while ago with John.
> > > This would make most sense to me, though we are using git's test
> > > harness, and I'd like to avoid making invasive changes in that, if
> > > possible.
> >
> > We do already build the Git tools when building the test target (as
> > opposed to just libgit.a when building the cgit binary), but I can't
> > remember why we do this...
> >
> > It's probably simplest just to further tweak $PATH in tests/setup.sh so
> > it also prepends "$(pwd)/../../git/bin-wrappers". That should cause us
> > to use the Git tools from the submodule without needing to do anything
> > else.
>
> That sounds like a good idea to me. Do you want to prepare a patch?
Now that I've dug into this some more, it turns out that we're already
using the Git tools from the submodule! The Git test framework already
sets up the path to use the tools from the Git tree, which explains why
the Makefile makes sure we build the Git CLI utilities.
next prev parent reply other threads:[~2014-01-09 20:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 18:45 [PATCH 1/2] README: Spelling and formatting fixes cgit
2014-01-08 18:45 ` [PATCH 2/2] README: Update dependencies cgit
2014-01-08 21:05 ` Jason
2014-01-09 7:30 ` cgit
2014-01-09 15:13 ` Jason
2014-01-09 18:01 ` john
2014-01-09 19:26 ` cgit
2014-01-09 20:10 ` john [this message]
2014-01-09 18:44 ` [PATCH v2] README: Fix dependencies cgit
2014-01-09 18:55 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109201035.GL7608@serenity.lan \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).