From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: [PATCH] Disallow downloading disabled snapshot formats
Date: Fri, 10 Jan 2014 18:14:50 +0100 [thread overview]
Message-ID: <20140110171450.15387.94020@typhoon.lan> (raw)
In-Reply-To: <CAHmME9pkeiuPumvbUJbtMqZM6s2G-TFw8qfyaJiaKBZFq+TZmg@mail.gmail.com>
On Fri, 10 Jan 2014 at 17:11:46, Jason A. Donenfeld wrote:
> On Fri, Jan 10, 2014 at 3:38 PM, Lukas Fleischer <cgit at cryptocrack.de> wrote:
> > We did only display enabled snapshot formats but we did not prevent from
> > downloading disabled formats when requested. Fix this by adding an
> > appropriate check.
>
> Previously:
> http://lists.zx2c4.com/pipermail/cgit/2012-June/000641.html
> http://lists.zx2c4.com/pipermail/cgit/2012-October/000792.html
I was also thinking of server load. If we want to leave it as-is, we
should fix the documentation which currently says:
repo.snapshots::
A mask of allowed snapshot-formats for this repo, restricted by
the "snapshots" global setting. Default value: <snapshots>.
There should at least be a note stating that "allowed" only means
"linked" here.
prev parent reply other threads:[~2014-01-10 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 14:38 cgit
2014-01-10 14:50 ` john
2014-01-10 15:02 ` cgit
2014-01-10 16:11 ` Jason
2014-01-10 17:14 ` cgit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140110171450.15387.94020@typhoon.lan \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).