From mboxrd@z Thu Jan  1 00:00:00 1970
From: cgit at cryptocrack.de (Lukas Fleischer)
Date: Mon, 13 Jan 2014 09:31:39 +0100
Subject: [PATCH 06/12] filter: add preliminary lua support
In-Reply-To: <1389586279-23724-7-git-send-email-Jason@zx2c4.com>
References: <1389586279-23724-1-git-send-email-Jason@zx2c4.com>
 <1389586279-23724-7-git-send-email-Jason@zx2c4.com>
Message-ID: <20140113083139.1499.53741@typhoon.lan>

This patch is quite messy and hard to read. I read your cover-letter but
maybe you still want to clean this up when dealing with the other
suggestions during a rebase -- shouldn't be too hard when using an
editor with good Git integration (like fugitive for Vim).

On Mon, 13 Jan 2014 at 05:11:13, Jason A. Donenfeld wrote:
> [...]
> +ifdef NO_LUA

We should document this in the installation instructions section in the
README. I also wonder whether this should made an opt-in feature?

> +       CFLAGS += -DNO_LUA
> +else
> +       CGIT_LIBS += -llua

Similar: Add Lua/LuaJIT (Will you squash the LuaJIT Makefile fix into
this one? Or is there any reason to use Lua first and switch to LuaJIT
later?) to the dependencies section of the README file and mention that
it is optional.

> +endif
> +
> +CGIT_LIBS += -ldl
> +
> +
> +
>  CGIT_OBJ_NAMES += cgit.o
>  CGIT_OBJ_NAMES += cache.o
>  CGIT_OBJ_NAMES += cmd.o
> [...]