List for cgit developers and users
 help / color / mirror / Atom feed
From: john at keeping.me.uk (John Keeping)
Subject: lua vs luajit vs both
Date: Tue, 14 Jan 2014 09:08:34 +0000	[thread overview]
Message-ID: <20140114090834.GZ7608@serenity.lan> (raw)
In-Reply-To: <CAHmME9pMcrZ=sJ=u-2fSONef+4beNEogf2vYzbfH3AuRLMFgAw@mail.gmail.com>

On Tue, Jan 14, 2014 at 02:02:40AM +0100, Jason A. Donenfeld wrote:
> I've gone ahead and merged the lua work to master, for testing and
> subsequent cleanup before release.
> 
> Regarding "to jit or not to jit", I currently have this fancy autodetection
> logic:
> http://git.zx2c4.com/cgit/commit/?id=3488d124052f5c3ddef303ed5306ad6a458794c1
> 
> John -- I'm waiting for your input on the parent email, as you seem to be
> the originator of the opinion that "both are good".

It was more of a "there doesn't seem much overhead to supporting both,
since the API is the same".  I think the Makefile should take an
approach more like this though:

	ifdef NO_LUA
		CGIT_CFLAGS += -DNO_LUA
	else if defined(USE_LUAJIT)
		# LuaJIT code goes here
	else
		# Lua code goes here
	endif

Basically, use vanilla Lua by default by provide an easy way for users
to switch to LuaJIT if they want.


  reply	other threads:[~2014-01-14  9:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-13 16:03 Jason
2014-01-14  1:02 ` Jason
2014-01-14  9:08   ` john [this message]
2014-01-14 18:06     ` Jason
2014-01-14 22:54       ` john

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140114090834.GZ7608@serenity.lan \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).