From: john at keeping.me.uk (John Keeping)
Subject: Policy on global variables
Date: Thu, 16 Jan 2014 21:34:24 +0000 [thread overview]
Message-ID: <20140116213424.GI7608@serenity.lan> (raw)
In-Reply-To: <CAHmME9qYcCniYEU7RU0OK-ZsKge+EZpXNVvt=H93og2WjyffSg@mail.gmail.com>
On Thu, Jan 16, 2014 at 10:26:08PM +0100, Jason A. Donenfeld wrote:
> On Thu, Jan 16, 2014 at 10:21 PM, John Keeping <john at keeping.me.uk> wrote:
> > The first step in this direction may actually be useful even if we stick
> > with embedding libgit.a.
>
> So what do you think ought to be done with the global-ctx patch? Merge
> it, and then refactor afterward (whenever we "step in this
> direction"), to get rid of the global? Or use what we have now
> (without the patch) as a starting point for gradually getting rid of
> the global?
I'm not sure it makes much difference either way. Even if we use
libgit2, providing we're not processing more than one request at once we
can still use a global cgit_context.
next prev parent reply other threads:[~2014-01-16 21:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 0:06 Jason
2014-01-16 0:20 ` Jason
2014-01-16 0:59 ` normalperson
2014-01-16 1:00 ` Jason
2014-01-16 8:06 ` hjemli
2014-01-16 10:47 ` normalperson
2014-01-16 11:31 ` Jason
2014-01-16 13:08 ` john
2014-01-16 18:38 ` Jason
2014-01-16 21:21 ` john
2014-01-16 21:26 ` Jason
2014-01-16 21:34 ` john [this message]
2014-01-16 21:36 ` Jason
2014-01-16 22:20 ` john
2014-01-16 23:42 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140116213424.GI7608@serenity.lan \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).