From mboxrd@z Thu Jan  1 00:00:00 1970
From: john at keeping.me.uk (John Keeping)
Date: Thu, 16 Jan 2014 21:34:24 +0000
Subject: Policy on global variables
In-Reply-To: <CAHmME9qYcCniYEU7RU0OK-ZsKge+EZpXNVvt=H93og2WjyffSg@mail.gmail.com>
References: <CAHmME9rKGfPx6ppX3VtN06Cd0YpAGCuzM4WW5A-sg7i3q6ZoTg@mail.gmail.com>
 <20140116005912.GA20306@dcvr.yhbt.net>
 <CAHmME9qWGtso5o+ao0FpsaVO_3ZoRbwoOK1G3Tp2aWtsD0iF2w@mail.gmail.com>
 <CAFXTnz47EV_xFnz_7oNRZzeqaAWq6E0LcJFmmiy502TQ3KpTUA@mail.gmail.com>
 <20140116104751.GA26678@dcvr.yhbt.net>
 <CAHmME9qFQQaYbedFrVUdhE6ShSCJAQsMjzTbqYFTFd54pRw-Jw@mail.gmail.com>
 <20140116130844.GF7608@serenity.lan>
 <CAHmME9oU=4JZA9AX-f5BfKd_MeMH-k5_M+0fegBkhs4eiTMWhQ@mail.gmail.com>
 <20140116212152.GH7608@serenity.lan>
 <CAHmME9qYcCniYEU7RU0OK-ZsKge+EZpXNVvt=H93og2WjyffSg@mail.gmail.com>
Message-ID: <20140116213424.GI7608@serenity.lan>

On Thu, Jan 16, 2014 at 10:26:08PM +0100, Jason A. Donenfeld wrote:
> On Thu, Jan 16, 2014 at 10:21 PM, John Keeping <john at keeping.me.uk> wrote:
> > The first step in this direction may actually be useful even if we stick
> > with embedding libgit.a.
> 
> So what do you think ought to be done with the global-ctx patch? Merge
> it, and then refactor afterward (whenever we "step in this
> direction"), to get rid of the global? Or use what we have now
> (without the patch) as a starting point for gradually getting rid of
> the global?

I'm not sure it makes much difference either way.  Even if we use
libgit2, providing we're not processing more than one request at once we
can still use a global cgit_context.