From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: [PATCH 2/2] Add a cache-snapshot-ttl configuration variable
Date: Wed, 05 Feb 2014 16:09:14 +0100 [thread overview]
Message-ID: <20140205150914.15574.47084@typhoon.lan> (raw)
In-Reply-To: <CAHmME9qpS2EbU3Z3S8xM9JJMGvbTyWiALbHZrvo8o9y9BZtrmg@mail.gmail.com>
On Wed, 05 Feb 2014 at 15:44:36, Jason A. Donenfeld wrote:
> On Wed, Feb 5, 2014 at 10:46 AM, Lukas Fleischer <cgit at cryptocrack.de> wrote:
> > This can be used to specify the TTL for snapshots. Snapshots are usually
> > static and do not ever change. On the other hand, tarball generation is
> > CPU intensive.
> >
> > One use case of this setting (apart from increasing the lifetime of
> > snapshot cache slots) is caching of snapshots while disabling the cache
> > for static/dynamic HTML pages (by setting TTL to zero for everything
> > except for snapshot requests).
> >
>
> I like this idea. But I don't think the default should be -1, since
> that significantly changes the current behavior, and makes certain
> tarballs get out of date perpetually, like downloading a zip of HEAD
> or what happens when history is rewritten.
Right, I didn't think of that. Only thought of the main use case which
is downloading tagged snapshots. These are unlikely to change. I really
wish we had some kind of intelligent caching as described in [1]. Using
that, we could unquestionably use -1 as default everywhere.
>
> Currently it defaults to cache_repo_ttl, which is 5. I'd be willing to
> compromise for 15 if you prefer.
I'm fine with either one. Whatever you prefer.
[1] http://lists.zx2c4.com/pipermail/cgit/2014-February/001974.html
next prev parent reply other threads:[~2014-02-05 15:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 9:46 [PATCH 0/2] Add an option to cache snapshots cgit
2014-02-05 9:46 ` [PATCH 1/2] Skip cache slot when time-to-live is zero cgit
2014-02-06 19:52 ` Jason
2014-02-06 21:07 ` cgit
[not found] ` <CAHmME9q805o8hczd1MW1Mw+DzJzRmE-5C9i6CB+cX2um_R=+yA@mail.gmail.com>
2014-02-08 13:41 ` Jason
2014-02-08 13:45 ` cgit
2014-02-20 18:58 ` Jason
2014-02-20 19:59 ` [PATCH] " cgit
2014-02-20 20:03 ` Jason
2014-02-20 20:07 ` cgit
2014-02-21 0:37 ` Jason
2014-02-05 9:46 ` [PATCH 2/2] Add a cache-snapshot-ttl configuration variable cgit
2014-02-05 14:44 ` Jason
2014-02-05 15:09 ` cgit [this message]
2014-02-08 13:36 ` cgit
2014-02-20 18:56 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140205150914.15574.47084@typhoon.lan \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).