From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: [PATCH 1/1] print download link for reference string length == 1
Date: Thu, 20 Feb 2014 21:15:17 +0100 [thread overview]
Message-ID: <20140220201517.6699.93263@typhoon.lan> (raw)
In-Reply-To: <20140220205853.564cbae2@leda.localdomain>
On Thu, 20 Feb 2014 at 20:58:53, Christian Hesse wrote:
> Christian Hesse <mail at eworm.de> on Thu, 2014/02/20 20:48:
> > I have a number of repositories that start tagging with just '1' and
> > count up. Actually references with sting length of one are skipped, this
> > patch changes that.
>
> Wondering if there was a good reason to use a minimum string length of two...
> Can my patch break anything? As far as I can tell is works without problems
> for me.
I can only guess because this code was added when the function was
introduced in commit 65962685 (ui-refs.c: show download links for all
tags referring to commit objects, 2008-12-01). I think it is related to
the code below accessing ref[1], though. I don't see how anything could
go wrong when the string length is 1 since isdigit('\0') should return
0 in that case. +1 from me.
> --
> main(a){char*c=/* Schoene Gruesse */"B?IJj;MEH"
> "CX:;",b;for(a/* Chris get my mail address: */=0;b=c[a++];)
> putchar(b-1/(/* gcc -o sig sig.c && ./sig */b/42*2-3)*42);}
>
>
> _______________________________________________
> CGit mailing list
> CGit at lists.zx2c4.com
> http://lists.zx2c4.com/mailman/listinfo/cgit
next prev parent reply other threads:[~2014-02-20 20:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 19:10 maintenance release coming soon Jason
2014-02-20 19:33 ` list
2014-02-20 19:35 ` Jason
2014-02-20 19:57 ` list
2014-02-20 19:48 ` [PATCH 1/1] print download link for reference string length == 1 mail
2014-02-20 19:58 ` list
2014-02-20 20:15 ` cgit [this message]
2014-02-21 0:41 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220201517.6699.93263@typhoon.lan \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).