List for cgit developers and users
 help / color / mirror / Atom feed
From: john at keeping.me.uk (John Keeping)
Subject: Fwd: source-filter isn't getting applied
Date: Wed, 30 Jul 2014 08:57:30 +0100	[thread overview]
Message-ID: <20140730075730.GI26927@serenity.lan> (raw)
In-Reply-To: <CA+TJm36z7PqAGQ6jypWEoAZKohussyZ++HxB0KW0rOzfpaA1ag@mail.gmail.com>

On Wed, Jul 30, 2014 at 12:17:26AM -0400, Nik Nyby wrote:
> Great, this helped me debug the error. I looked at the part of the strace
> where it was reading the /etc/cgitrc, and it looked like it was only
> reading the first setting, even though the following settings are getting
> applied. I'm not sure exactly why yet, but putting the source-filter
> setting at the top of the /etc/cgitrc fixes the problem, and my source
> files are now highlighted.

I suspect that was just strace truncating the data, but at least it
pointed to the answer!

Global settings get frozen for each repository when it is added, so you
should generally do all the configuration near the top of the file and
then add repositories (either explicity or with "scan-path=...") near
the bottom.

> Now I'm dealing with the same problem with the about-filter, because
> putting that setting at the top isn't giving me markdown highlighting.
> 
> 
> On Tue, Jul 29, 2014 at 3:37 AM, John Keeping <john at keeping.me.uk> wrote:
> 
> > On Mon, Jul 28, 2014 at 11:59:10PM -0400, Nik Nyby wrote:
> > > The permissions on the script files are set to be executable by everyone:
> > > -rwxr-xr-x
> > >
> > > Thanks for the strace idea. I'm looking through the strace, but I haven't
> > > seen any helpful mention of the filter scripts yet. I've attached an
> > > abridged version of my strace with the middle of the file taken out. I
> > > don't know if this is helpful or not. I'll let you know if I solve the
> > > problem.
> >
> > If CGit was going to open a filter, it would do so after this line:
> >
> >         write(1, "<td class='lines'><pre><code>", 29) = 29
> >
> > So it looks like something in the configuration isn't being read
> > correctly, but I think you snipped the strace log before we could see
> > which config file it reads.


  parent reply	other threads:[~2014-07-30  7:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-28 21:14 njn2118
2014-07-28 22:38 ` john
     [not found]   ` <CA+TJm37SY1PwBuYgTpn=bQz0D7LcGdwwSZb=38ZbHK_DX1j5JA@mail.gmail.com>
2014-07-29  3:59     ` Fwd: " njn2118
2014-07-29  7:37       ` john
2014-07-30  4:17         ` njn2118
2014-07-30  4:21           ` njn2118
2014-07-30  7:57           ` john [this message]
2014-07-30 18:53 ` [PATCH] ui-tree.c: check source filter if set globally jamie.couture
2014-07-30 19:23   ` john
2014-07-30 20:47     ` jamie.couture
2014-07-30 21:06       ` jamie.couture
2014-07-30 21:14       ` john
2014-07-31  1:05         ` jamie.couture
2014-07-31  1:08           ` jamie.couture
2014-08-01 15:38             ` Jason
2014-07-30 15:10 Fwd: source-filter isn't getting applied njn2118

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140730075730.GI26927@serenity.lan \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).