From mboxrd@z Thu Jan 1 00:00:00 1970 From: cgit at cryptocrack.de (Lukas Fleischer) Date: Sat, 13 Dec 2014 11:59:06 +0100 Subject: Should remove-suffix=1 and scan-path work with non-bare repos? In-Reply-To: <53640519.166708.1418460094104.JavaMail.yahoo@jws10604.mail.bf1.yahoo.com> References: <53640519.166708.1418460094104.JavaMail.yahoo@jws10604.mail.bf1.yahoo.com> Message-ID: <20141213105906.5716.95194@typhoon.lan> On Sat, 13 Dec 2014 at 09:41:34, Charles Dee Rice wrote: > [...] > and a non-bare repot /tmp/testing/blah/.git, I see unexpected behavior for the "blah" repot. The repot is named "blah/" on the cgit index page (note trailing slash). The Summary page for "blah/" works as expected, but attempting to view any other data (refs, log, tree, etc), I receive a "No repositories found" error. > [...] > Should scanning + remove-suffix work with non-bare repots? Please forgive me if I have missed something simple -- I've been scratching my head on this for a while. Am I doing something silly or missing something in the documentation? > [...] While the trailing slash is technically correct, it does not look nice and does not match what we do in cgit_repobasename() -- so I consider this a bug. Could be please try the patch I am going to send in a second? Regards, Lukas