From mboxrd@z Thu Jan 1 00:00:00 1970 From: list at eworm.de (Christian Hesse) Date: Tue, 13 Jan 2015 10:57:39 +0100 Subject: [PATCH 1/1] git: preview for v2.3.0-rc0 In-Reply-To: <20150113094353.GD26383@serenity.lan> References: <1421139407-15727-1-git-send-email-list@eworm.de> <20150113094353.GD26383@serenity.lan> Message-ID: <20150113105739.1043e130@leda.localdomain> John Keeping on Tue, 2015/01/13 09:43: > On Tue, Jan 13, 2015 at 09:56:47AM +0100, list at eworm.de wrote: > > From: Christian Hesse > > > > * sort_string_list(): rename to string_list_sort() (upstream commit > > 3383e199) > > * update read_tree_recursive callback to pass strbuf as base (upstream > > commit 6a0b0b6d) > > > > Signed-off-by: Christian Hesse > > --- > > [...] > > Is there any benefit to introducing a new function here? In other > words, is walk_tree() used anywhere else? If not, wouldn't it be > simpler to update the signature of the existing function? > > (The same comment applies to several other places below.) I just adopted the changes from git upstream to make things work. This is not intended for merge... And I will take a closer look for final patch when git v2.3.0 arrives. ;) Our code include three functions called 'walk_tree()' in ui-plain.c, ui-blob.c and ui-tree.c. Can this bring any trouble? -- main(a){char*c=/* Schoene Gruesse */"B?IJj;MEH" "CX:;",b;for(a/* Chris get my mail address: */=0;b=c[a++];) putchar(b-1/(/* gcc -o sig sig.c && ./sig */b/42*2-3)*42);} -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 473 bytes Desc: OpenPGP digital signature URL: