From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: log of tags
Date: Thu, 15 Jan 2015 18:27:50 +0100 [thread overview]
Message-ID: <20150115172750.10348.53323@typhoon.lan> (raw)
In-Reply-To: <54B7E83A.5010309@hupie.com>
On Thu, 15 Jan 2015 at 17:18:02, Ferry Huberts wrote:
> Hi
>
> Just noticed this:
> You can't show the log of a tag when that tag is not on a branch, which
> happen to me a lot for expired maintenance branches.
>
> Sound familiar?
>
> How to fix?
> Include a 'log' line, like the 'Tagged object' line?
> Or just make clicking on the log 'tab' do the right thing? (it currently
> just shows the log of the default branch)
> [...]
Making the "log" link point to the log of the currently selected commit
is easy but I do not know whether that is what we want to do. It is a
convenient way to navigate back to the "full" log and I think this is
what most users would expect. Note that you can always manually append
"?id=$tag" to the log URI which is what I sometimes do when posting
links to the log of a release somewhere.
Anyway, if you still want the "make clicking on the log 'tab' do the
right thing" behavior, try this (untested):
-- >8 --
diff --git a/ui-shared.c b/ui-shared.c
index 32f23f9..2eb0d4e 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -928,7 +928,7 @@ void cgit_print_pageheader(void)
cgit_refs_link("refs", NULL, hc("refs"), ctx.qry.head,
ctx.qry.sha1, NULL);
cgit_log_link("log", NULL, hc("log"), ctx.qry.head,
- NULL, ctx.qry.vpath, 0, NULL, NULL,
+ ctx.qry.sha1, ctx.qry.vpath, 0, NULL, NULL,
ctx.qry.showmsg);
cgit_tree_link("tree", NULL, hc("tree"), ctx.qry.head,
ctx.qry.sha1, ctx.qry.vpath);
next prev parent reply other threads:[~2015-01-15 17:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 16:18 mailings
2015-01-15 17:27 ` cgit [this message]
2015-01-15 21:55 ` john
2015-01-15 22:18 ` [PATCH] tag: reference with "h" instead of "id" john
2015-01-15 22:23 ` mailings
2015-01-19 16:52 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150115172750.10348.53323@typhoon.lan \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).