From: john at keeping.me.uk (John Keeping)
Subject: [PATCH] Simplify commit and tag parsing
Date: Thu, 5 Mar 2015 10:52:43 +0000 [thread overview]
Message-ID: <20150305105243.GC1369@serenity.lan> (raw)
In-Reply-To: <CAHmME9pa00Ddzpyc-B65-1hx5SqEsJrMZfpFAQuidTbQPx3rEQ@mail.gmail.com>
On Thu, Mar 05, 2015 at 11:46:55AM +0100, Jason A. Donenfeld wrote:
> This commit breaks ui-tag. The first few lines of tag messages are cut off.
It looks like parse_user() consumes the trailing LF on the user line, so
next_header_line() ends up skipping the blank line at the end of the
header.
I suspect the right answer is to stop parse_user() eating the LF since
all of the call sites go through next_header_line() after this patch.
prev parent reply other threads:[~2015-03-05 10:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 12:00 cgit
2015-03-03 15:46 ` Jason
2015-03-05 10:46 ` Jason
2015-03-05 10:52 ` john [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150305105243.GC1369@serenity.lan \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).