From: john at keeping.me.uk (John Keeping)
Subject: Support for submodules in tree view?
Date: Fri, 6 Mar 2015 09:09:30 +0000 [thread overview]
Message-ID: <20150306090930.GH1369@serenity.lan> (raw)
In-Reply-To: <9AD8B655B5126D4FAE1397203CDDBF2D12CCA2@XCH-PHX-213.sw.nos.boeing.com>
On Fri, Mar 06, 2015 at 05:58:21AM +0000, Dunnigan, Terrence J wrote:
> Do you have an example or two of values for module-link? I didn't see
> an example on the sample config file at
> http://git.zx2c4.com/cgit/tree/cgitrc.5.txt
git-instacgit[0] autogenerates submodule links as:
module-link=/cgit/submodule/%s/commit?id=%s
then adds the submodule repositories as something like:
repo.url=submodule/git
repo.path=/home/john/src/cgit/.git/modules/git
where the "repo.url" value is simply "submodule/${sm_path}".
Because this "module-link" only gets the path at which the submodule is
installed in the parent repository, I think this is hard to use in a
generic way.
> If both module-link and repo.module-link are present, would
> repo.module-link override the global module-link?
Yes.
[0] https://github.com/johnkeeping/git-instacgit
> -----Original Message-----
> From: John Keeping [mailto:john at keeping.me.uk]
> Sent: Thursday, March 05, 2015 12:26 PM
> To: Dunnigan, Terrence J
> Cc: cgit at lists.zx2c4.com
> Subject: Re: Support for submodules in tree view?
>
> On Thu, Mar 05, 2015 at 06:19:31PM +0000, Dunnigan, Terrence J wrote:
> > We are using cgit 0.10.1. Some of our repos have submodules, and when
> > I look at a tree view I see the name of the submodule with its current
> > hash, e.g.
> >
> > m--------- Utilities @ 350bc94
> >
> > The submodule names are all hyperlinks, but the actual link is just a
> > "#". So clicking on it doesn't do anything.
> >
> > Is this the correct behavior? Or something on my system improperly
> > configured to support submodules?
>
> You probably need to set the "module-link" configuration variable in your cgitrc file.
>
> Since it's possible for submodules to link to a different server, there isn't really much CGit can do in the general case. Note that there's also "repo.module-link.<path>" in case your submodule paths don't match up to their URLs, although I'm quite surprised we don't support a filter to map submodule URLs to links - something to go on the TODO list perhaps...
> _______________________________________________
> CGit mailing list
> CGit at lists.zx2c4.com
> http://lists.zx2c4.com/mailman/listinfo/cgit
prev parent reply other threads:[~2015-03-06 9:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 18:19 terrence.j.dunnigan
2015-03-05 18:25 ` john
2015-03-05 18:31 ` cgit
2015-03-05 18:34 ` john
2015-03-06 5:58 ` terrence.j.dunnigan
2015-03-06 9:09 ` john [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150306090930.GH1369@serenity.lan \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).