From mboxrd@z Thu Jan  1 00:00:00 1970
From: john at keeping.me.uk (John Keeping)
Date: Fri, 20 Mar 2015 21:29:50 +0000
Subject: [PATCH] ui-commit: display commit notes as 'raw'
In-Reply-To: <1426869593-10432-1-git-send-email-stefan.naewe@gmail.com>
References: <1426869593-10432-1-git-send-email-stefan.naewe@gmail.com>
Message-ID: <20150320212950.GA1344@serenity>

On Fri, Mar 20, 2015 at 05:39:53PM +0100, Stefan Naewe wrote:
> When the git function format_display_notes() is called
> with a value != 0 as the last argument ('raw') the notes text
> gets displayed w/o an additional 'Notes:' header. This seems
> to be better suited for our needs since we're already displaying
> a similar header.

What happens when there are multiple display notes refs?  It seems that
without "raw", format_note() puts the name of the ref in the header it
prints (if it's not the default notes ref).

It's possible that the correct answer is that we don't care about that
case, but it is potentially a regression for people who want to display
multiple notes.

> Signed-off-by: Stefan Naewe <stefan.naewe at gmail.com>
> ---
>  ui-commit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ui-commit.c b/ui-commit.c
> index d5a888d..4b40133 100644
> --- a/ui-commit.c
> +++ b/ui-commit.c
> @@ -37,7 +37,7 @@ void cgit_print_commit(char *hex, const char *prefix)
>  	}
>  	info = cgit_parse_commit(commit);
>  
> -	format_display_notes(sha1, &notes, PAGE_ENCODING, 0);
> +	format_display_notes(sha1, &notes, PAGE_ENCODING, 1);
>  
>  	load_ref_decorations(DECORATE_FULL_REFS);
>