From: john at keeping.me.uk (John Keeping)
Subject: [PATCH 16/17] tree: move layout into page function
Date: Sun, 5 Apr 2015 19:31:45 +0100 [thread overview]
Message-ID: <20150405183145.GH21452@serenity.lan> (raw)
In-Reply-To: <4a6b6be5e33d5d8a0d8ec8d6e8776a895a960b26.1428248621.git.john@keeping.me.uk>
On Sun, Apr 05, 2015 at 04:55:02PM +0100, John Keeping wrote:
> This also allows us to return proper HTTP error codes when the requested
> tree is not found and display an error message in one case (invalid path
> inside valid commit) where we previously just displayed an empty page.
>
> Signed-off-by: John Keeping <john at keeping.me.uk>
> ---
This breaks displaying file contents in tree view; it needs something
like this squashed into it, which has the advantage of making a couple
more errors return proper HTTP status codes but indicates how
complicated the layout setup in ui-tree.c becomes:
diff --git a/ui-tree.c b/ui-tree.c
index 4c1f9cb..70ea2ea 100644
--- a/ui-tree.c
+++ b/ui-tree.c
@@ -93,16 +93,19 @@ static void print_object(const unsigned char *sha1, char *path, const char *base
type = sha1_object_info(sha1, &size);
if (type == OBJ_BAD) {
- cgit_print_error("Bad object name: %s", sha1_to_hex(sha1));
+ cgit_print_error_page(404, "Not found",
+ "Bad object name: %s", sha1_to_hex(sha1));
return;
}
buf = read_sha1_file(sha1, &type, &size);
if (!buf) {
- cgit_print_error("Error reading object %s", sha1_to_hex(sha1));
+ cgit_print_error_page(500, "Internal server error",
+ "Error reading object %s", sha1_to_hex(sha1));
return;
}
+ cgit_print_layout_start();
htmlf("blob: %s (", sha1_to_hex(sha1));
cgit_plain_link("plain", NULL, NULL, ctx.qry.head,
rev, path);
@@ -235,6 +238,7 @@ static int walk_tree(const unsigned char *sha1, struct strbuf *base,
ls_head();
return READ_TREE_RECURSIVE;
} else {
+ walk_tree_ctx->state = 2;
print_object(sha1, buffer, pathname, walk_tree_ctx->curr_rev);
return 0;
}
@@ -290,6 +294,8 @@ void cgit_print_tree(const char *rev, char *path)
read_tree_recursive(commit->tree, "", 0, 0, &paths, walk_tree, &walk_tree_ctx);
if (walk_tree_ctx.state == 1)
ls_tail();
+ else if (walk_tree_ctx.state == 2)
+ cgit_print_layout_end();
else
cgit_print_error_page(404, "Not found", "Path not found");
> cmd.c | 2 +-
> ui-tree.c | 13 ++++++++++---
> 2 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/cmd.c b/cmd.c
> index 27408f2..6a964b1 100644
> --- a/cmd.c
> +++ b/cmd.c
> @@ -161,7 +161,7 @@ struct cgit_cmd *cgit_get_cmd(void)
> def_cmd(stats, 1, 0, 1, 0),
> def_cmd(summary, 1, 0, 0, 0),
> def_cmd(tag, 1, 0, 0, 0),
> - def_cmd(tree, 1, 1, 1, 0),
> + def_cmd(tree, 1, 0, 1, 0),
> };
> int i;
>
> diff --git a/ui-tree.c b/ui-tree.c
> index bbc468e..4c1f9cb 100644
> --- a/ui-tree.c
> +++ b/ui-tree.c
> @@ -182,6 +182,7 @@ static int ls_item(const unsigned char *sha1, struct strbuf *base,
>
> static void ls_head(void)
> {
> + cgit_print_layout_start();
> html("<table summary='tree listing' class='list'>\n");
> html("<tr class='nohover'>");
> html("<th class='left'>Mode</th>");
> @@ -194,6 +195,7 @@ static void ls_head(void)
> static void ls_tail(void)
> {
> html("</table>\n");
> + cgit_print_layout_end();
> }
>
> static void ls_tree(const unsigned char *sha1, char *path, struct walk_tree_context *walk_tree_ctx)
> @@ -205,7 +207,8 @@ static void ls_tree(const unsigned char *sha1, char *path, struct walk_tree_cont
>
> tree = parse_tree_indirect(sha1);
> if (!tree) {
> - cgit_print_error("Not a tree object: %s", sha1_to_hex(sha1));
> + cgit_print_error_page(400, "Bad request",
> + "Not a tree object: %s", sha1_to_hex(sha1));
> return;
> }
>
> @@ -266,12 +269,14 @@ void cgit_print_tree(const char *rev, char *path)
> rev = ctx.qry.head;
>
> if (get_sha1(rev, sha1)) {
> - cgit_print_error("Invalid revision name: %s", rev);
> + cgit_print_error_page(404, "Not found",
> + "Invalid revision name: %s", rev);
> return;
> }
> commit = lookup_commit_reference(sha1);
> if (!commit || parse_commit(commit)) {
> - cgit_print_error("Invalid commit reference: %s", rev);
> + cgit_print_error_page(404, "Not found",
> + "Invalid commit reference: %s", rev);
> return;
> }
>
> @@ -285,6 +290,8 @@ void cgit_print_tree(const char *rev, char *path)
> read_tree_recursive(commit->tree, "", 0, 0, &paths, walk_tree, &walk_tree_ctx);
> if (walk_tree_ctx.state == 1)
> ls_tail();
> + else
> + cgit_print_error_page(404, "Not found", "Path not found");
>
> cleanup:
> free(walk_tree_ctx.curr_rev);
> --
> 2.4.0.rc0.173.gb1cefcc
>
> _______________________________________________
> CGit mailing list
> CGit at lists.zx2c4.com
> http://lists.zx2c4.com/mailman/listinfo/cgit
next prev parent reply other threads:[~2015-04-05 18:31 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-05 15:54 [PATCH 00/17] HTTP response code improvements john
2015-04-05 15:54 ` [PATCH 01/17] ui-shared: add cgit_print_error_page() function john
2015-04-07 13:23 ` Jason
2015-04-07 13:32 ` john
2015-04-07 13:36 ` Jason
2015-04-07 18:17 ` john
2015-04-05 15:54 ` [PATCH 02/17] cgit: use cgit_print_error_page() where appropriate john
2015-04-05 15:54 ` [PATCH 03/17] clone: use cgit_print_error_page() instead of html_status() john
2015-04-05 15:54 ` [PATCH 04/17] plain: " john
2015-04-05 15:54 ` [PATCH 05/17] snapshot: " john
2015-04-05 15:54 ` [PATCH 06/17] html: remove html_status() john
2015-04-05 15:54 ` [PATCH 07/17] ui-shared: add cgit_print_layout_{start,end}() john
2015-04-05 15:54 ` [PATCH 08/17] about: move layout into page functions john
2015-04-05 15:54 ` [PATCH 09/17] commit: move layout into page function john
2015-04-05 15:54 ` [PATCH 10/17] diff: move layout to " john
2015-04-05 15:54 ` [PATCH 11/17] log: move layout into " john
2015-04-05 15:54 ` [PATCH 12/17] refs: move layout to " john
2015-04-05 15:54 ` [PATCH 13/17] stats: move layout into " john
2015-04-05 15:55 ` [PATCH 14/17] summary: " john
2015-04-05 15:55 ` [PATCH 15/17] tag: " john
2015-04-05 15:55 ` [PATCH 16/17] tree: " john
2015-04-05 18:31 ` john [this message]
2015-04-05 15:55 ` [PATCH 17/17] cmd: remove "want_layout" field john
2015-04-05 16:28 ` [PATCH 00/17] HTTP response code improvements john
2015-08-14 11:47 ` [PATCH v2 00/22] HTTP status " john
2015-08-14 11:47 ` [PATCH v2 01/22] ui-shared: add cgit_print_error_page() function john
2015-08-14 11:47 ` [PATCH v2 02/22] cgit: use cgit_print_error_page() where appropriate john
2015-08-14 11:47 ` [PATCH v2 03/22] clone: use cgit_print_error_page() instead of html_status() john
2015-08-14 11:47 ` [PATCH v2 04/22] plain: " john
2015-08-14 11:47 ` [PATCH v2 05/22] snapshot: " john
2015-08-14 11:47 ` [PATCH v2 06/22] blob: use cgit_print_error_page() to add HTTP headers john
2015-08-14 11:47 ` [PATCH v2 07/22] patch: use cgit_print_error_page() for HTTP status codes john
2015-08-14 11:47 ` [PATCH v2 08/22] snapshot: " john
2015-08-14 11:47 ` [PATCH v2 09/22] snapshot: don't reimplement cgit_print_error_page() john
2015-08-14 11:47 ` [PATCH v2 10/22] html: remove html_status() john
2015-08-14 11:47 ` [PATCH v2 11/22] ui-shared: add cgit_print_layout_{start,end}() john
2015-08-14 11:47 ` [PATCH v2 12/22] about: move layout into page functions john
2015-08-14 11:47 ` [PATCH v2 13/22] commit: move layout into page function john
2015-08-14 11:47 ` [PATCH v2 14/22] diff: move layout to " john
2015-08-14 11:47 ` [PATCH v2 15/22] log: move layout into " john
2015-08-14 11:47 ` [PATCH v2 16/22] refs: move layout to " john
2015-08-14 11:47 ` [PATCH v2 17/22] stats: move layout into " john
2015-08-14 11:47 ` [PATCH v2 18/22] summary: " john
2015-08-14 11:47 ` [PATCH v2 19/22] tag: " john
2015-08-14 11:47 ` [PATCH v2 20/22] tree: " john
2015-08-14 11:47 ` [PATCH v2 21/22] cmd: remove "want_layout" field john
2015-08-14 11:47 ` [PATCH v2 22/22] ui-shared: cache errors for "dynamic TTL" john
2015-08-14 12:17 ` [PATCH v2 00/22] HTTP status code improvements nicolas.dely
2015-08-14 13:56 ` Jason
2015-08-14 14:20 ` john
2015-08-14 14:24 ` list
2015-08-14 14:40 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150405183145.GH21452@serenity.lan \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).