From mboxrd@z Thu Jan  1 00:00:00 1970
From: john at keeping.me.uk (John Keeping)
Date: Thu, 18 Jun 2015 16:07:35 +0100
Subject: disable logo-link ?
In-Reply-To: <CAC1BbcQpzbBmtcG4tUjeRvVT4OZQtNg1hP_eWXrcfs-bcEzhUw@mail.gmail.com>
References: <CAC1BbcRuh_hbVMPBHXx3MQ1XHxOQ0RrFaFZTcx6xQEdyiSRhCA@mail.gmail.com>
 <20150618144813.GM18226@serenity.lan>
 <CAC1BbcQpzbBmtcG4tUjeRvVT4OZQtNg1hP_eWXrcfs-bcEzhUw@mail.gmail.com>
Message-ID: <20150618150735.GN18226@serenity.lan>

On Thu, Jun 18, 2015 at 05:03:35PM +0200, Bernhard Reutner-Fischer wrote:
> On 18 June 2015 at 16:48, John Keeping <john at keeping.me.uk> wrote:
> > On Thu, Jun 18, 2015 at 04:38:32PM +0200, Bernhard Reutner-Fischer wrote:
> >> A colleague asked if it's possible to disable the logo-link, but that
> >> doesn't seem to work right now?
> >
> > No, if there isn't a logo-link specified then the CGit root URL is used;
> > see ui-shared.c:
> >
> >         if (logo_link && *logo_link)
> >                 html_attr(logo_link);
> >         else
> >                 html_attr(cgit_rooturl());
> 
> yes, anyone got an idea on a token to disable it?
> 
> maybe:
> logo-link=

It looks like that would have (sort of) worked prior to commit 808c685
(implement repo.logo and repo.logo-link, 2010-12-23), although it would
have had "href=''" in the generated HTML.

> As a second "issue", what about a logo-alt instead of the hardcoded
>                 html("'><img src='");
>                 html_attr(logo);
>                 html("' alt='cgit logo'/></a></td>\n");
> 
> in print_header() ?

Good idea.