From: john at keeping.me.uk (John Keeping)
Subject: Build failed in Jenkins: cgit - upstream - get-git - master #190 - remotes/origin/master - a360666
Date: Thu, 13 Aug 2015 15:54:37 +0100 [thread overview]
Message-ID: <20150813145437.GO30507@serenity.lan> (raw)
In-Reply-To: <55CCAB47.80600@hupie.com>
On Thu, Aug 13, 2015 at 04:35:51PM +0200, Ferry Huberts wrote:
>
>
> On 13/08/15 16:32, Jason A. Donenfeld wrote:
> > John -- why are their circumstances in which your config.mak.uname isn't
> > created?
>
> It's in the 'get-git' build.
> So that is the build in which git is built from a 'release' tar instead
> of from its repo
And the problem is in the "get-git" stage, at which point the "git"
directory doesn't exist.
This fixes it:
-- >8 --
Subject: [PATCH] Makefile: make "git/config.mak.uname" inclusion optional
If we haven't got a "git" directory, it should still be possible to run
"make get-git", so we cannot include this file unconditionally.
Signed-off-by: John Keeping <john at keeping.me.uk>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 74061a3..a0a6615 100644
--- a/Makefile
+++ b/Makefile
@@ -33,7 +33,7 @@ DOC_PDF = $(patsubst %.txt,%.pdf,$(MAN_TXT))
#-include config.mak
-include git/config.mak.uname
+-include git/config.mak.uname
#
# Let the user override the above settings.
#
--
2.5.0.466.g9af26fa
next prev parent reply other threads:[~2015-08-13 14:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1475968790.12.1439473391007.JavaMail.jenkins@jenkins-public.internal.hupie.com>
2015-08-13 14:28 ` Fwd: " mailings
2015-08-13 14:30 ` mailings
2015-08-13 14:32 ` Jason
2015-08-13 14:35 ` mailings
2015-08-13 14:54 ` john [this message]
2015-08-13 15:05 ` Jason
2015-08-13 16:00 ` mailings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150813145437.GO30507@serenity.lan \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).