From mboxrd@z Thu Jan 1 00:00:00 1970 From: john at keeping.me.uk (John Keeping) Date: Fri, 14 Aug 2015 15:20:23 +0100 Subject: [PATCH v2 00/22] HTTP status code improvements In-Reply-To: References: Message-ID: <20150814142023.GA1412@serenity.lan> On Fri, Aug 14, 2015 at 03:56:43PM +0200, Jason A. Donenfeld wrote: > Thanks for this series. The approach to caching seems like a decent > tradeoff. I'd be interested in hearing dissenting opinions on this > though. It's not to late to come up with something better before > release time. > > The set looks good, and I've gone ahead and merged it to master. This > also allowed me to add another patch ontop of it getting rid of the > cmd pre() function, which was nice. Nice, but it looks like you missed a bit... -- >8 -- Subject: [PATCH] cmd: fix command definition The previous commit removed the "pre" field from "struct cgit_cmd" but forgot to update this macro. Signed-off-by: John Keeping --- cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd.c b/cmd.c index 20c80b0..c991092 100644 --- a/cmd.c +++ b/cmd.c @@ -142,7 +142,7 @@ static void tree_fn(void) } #define def_cmd(name, want_repo, want_vpath, is_clone) \ - {#name, name##_fn, NULL, want_repo, want_vpath, is_clone} + {#name, name##_fn, want_repo, want_vpath, is_clone} struct cgit_cmd *cgit_get_cmd(void) { -- 2.5.0.466.g9af26fa