From: john at keeping.me.uk (John Keeping)
Subject: [PATCH 1/2] Compile with -Wstrict-prototypes -Wmissing-prototypes
Date: Thu, 14 Jan 2016 13:32:58 +0000 [thread overview]
Message-ID: <20160114133258.GJ14056@serenity.lan> (raw)
In-Reply-To: <CAHmME9qpV0RhtoVPZJEco63HgJ4ty-rdmvqibcPe001Yfjqcsw@mail.gmail.com>
On Thu, Jan 14, 2016 at 02:01:32PM +0100, Jason A. Donenfeld wrote:
> John - what compilers do you have in mind that don't accept this flag?
> I rather like it.
SunStudio certainly doesn't support these diagnostics.
I'm following what git.git does in this regard. If you check
git/Makefile you'll see that it sets -Wall but nothing else. Since our
makefile is derived from that I'd prefer to follow the same principle.
The important thing is that we maintain the CFLAGS/CGIT_CFLAGS split for
compiler tuning vs. "functional" flags; warnings are in the former
category and should be in CFLAGS but we need to think carefully about
where to add those and allow the user to override them. I think they
would have to go in cgit.mk between "include Makefile" and
"-include $(CGIT_PREFIX)cgit.conf" which allows users to override them
in cgit.conf but not in git/config.mak.
I would much rather that we add a wrapper akin to Junio's maintainer
"Make" for git.git [1] that compiles with these stricter flags rather
than modifying the default makefile and causing pain for those on less
common systems. It only takes a couple of people to have this turned on
for us to catch these issues reasonably quickly.
[1] https://github.com/git/git/blob/todo/Make
next prev parent reply other threads:[~2016-01-14 13:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 19:28 [PATCH] ui-repolist: return HTTP 404 if no repositories found peter
2015-12-07 19:28 ` peter
2015-12-07 20:28 ` john
2015-12-08 17:53 ` [PATCH v2 0/2] " peter
2015-12-08 17:53 ` [PATCH v2 1/2] ui-repolist: extract repo visibility criteria to separate function peter
2016-01-13 16:15 ` Jason
2015-12-08 17:53 ` [PATCH v2 2/2] ui-repolist: return HTTP 404 if no repositories found peter
2016-01-13 16:21 ` Jason
2016-01-13 22:25 ` peter
2016-01-13 22:25 ` [PATCH 1/2] Compile with -Wstrict-prototypes -Wmissing-prototypes peter
2016-01-13 23:29 ` john
2016-01-14 13:01 ` Jason
2016-01-14 13:12 ` mailings
2016-01-14 13:32 ` john [this message]
2016-01-14 13:35 ` Jason
2016-01-13 22:25 ` [PATCH 2/2] Fix missing prototype declarations peter
2016-01-14 13:02 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160114133258.GJ14056@serenity.lan \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).