From mboxrd@z Thu Jan 1 00:00:00 1970 From: john at keeping.me.uk (John Keeping) Date: Mon, 8 Feb 2016 14:08:44 +0000 Subject: [PATCH 0/8] Show times in the originator's timezone In-Reply-To: References: Message-ID: <20160208140844.GL29880@serenity.lan> On Mon, Feb 08, 2016 at 02:38:57PM +0100, Jason A. Donenfeld wrote: > This series is faulty. See git.zx2c4.com > > It shows (GMT) when those times are not GMT. You're right, it seems that the problem is that we end up using strftime(3) with %Z for the timezone, but that function doesn't take an explicit timezone so it just ends up using the system one. I think we should just switch to using DATE_SHORT and DATE_ISO8601 from Git's date_mode_type enum; I didn't do so originally because the format doesn't quite match what we have used traditionally, but now that I look again it's not that different so I reckon we should just switch (it was a bigger problem before Git learned that "local" is orthogonal to the display mode). We may still need a custom strftime(3) string for FMT_ATOMDATE, but DATE_ISO8601_STRICT may be enough; it depends whether atom dates have to be in +00:00 or not.