List for cgit developers and users
 help / color / mirror / Atom feed
From: john at keeping.me.uk (John Keeping)
Subject: [PATCH 1/1] css: use less blurry icon for external link
Date: Tue, 23 Feb 2016 10:07:07 +0000	[thread overview]
Message-ID: <20160223100707.GG1766@serenity.lan> (raw)
In-Reply-To: <1456220845-4573-1-git-send-email-list@eworm.de>

On Tue, Feb 23, 2016 at 10:47:25AM +0100, Christian Hesse wrote:
> Your mileage may vary, but for me the old icon looks blurry. The new
> one is character 0xf08e from OTF font awsome in size 10.
> The icon color is black, gray level is adjusted via opacity.

What's the licensing status of individual glyphs from Font Awesome?
IANAL but my reading of the OFL is that it's not compatible with the
GPL.

The nice thing about the icon from Wikipedia is that it's already
licensed under the GPLv2 so we don't have to worry about whether it's
compatible (although it might be a good idea to credit the source in a
comment).

> Signed-off-by: Christian Hesse <mail at eworm.de>
> ---
>  cgit.css | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/cgit.css b/cgit.css
> index 50f6587..f6f6e7c 100644
> --- a/cgit.css
> +++ b/cgit.css
> @@ -86,7 +86,8 @@ div#cgit table.tabs td a.active {
>  }
>  
>  div#cgit table.tabs a[href^="http://"]:after, div#cgit table.tabs a[href^="https://"]:after {
> -	content: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAQAAAAnOwc2AAAAAnNCSVQICFXsRgQAAAAJcEhZcwAAABQAAAAUAVyMgXwAAAAZdEVYdFNvZnR3YXJlAHd3dy5pbmtzY2FwZS5vcmeb7jwaAAAAeklEQVQI12NoYCu3q3ABwXL98vTy/0D4jaF8XXldRRoYejAwlu8BCTOU72SAg4q08j/le0GC22BC5anlfyrSGBiBGCZYllz+pywLJg8WLOMtf1GeCjRgI5IgSBhMboUIHq40r1CCQrfyDRAV6uXdZTMhsKKlVIIBFwAAVeg4KFYK95cAAAAASUVORK5CYII=);
> +	content: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAYAAACNMs+9AAAABmJLR0QA/wD/AP+gvaeTAAAACXBIWXMAAAsTAAALEwEAmpwYAAAAB3RJTUUH4AIXCQ0GPoJtkwAAAB1pVFh0Q29tbWVudAAAAAAAQ3JlYXRlZCB3aXRoIEdJTVBkLmUHAAAAg0lEQVQY05XPsQkCQRSE4e9OY61Ae7AGAxMT7cKKrgIrUMFMA8HUAuzAxAKUNdmFx7EX+KJhZvh50xi+JTZZvxusscMolG7Y44p5MU8YV4gzPJGQ2iw+ldIFLyzwgOMA6Y5JMdteaRpIK2xjGIlNHlZI5xL0RyR0IfvG4qHyZ6F3/r0fA3QYU9MQfpcAAAAASUVORK5CYII=);
> +	opacity: 0.5;
>  	margin: 0 0 0 5px;
>  }
>  


  reply	other threads:[~2016-02-23 10:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-23  9:47 list
2016-02-23 10:07 ` john [this message]
2016-02-23 10:14   ` list
2016-02-23 10:20     ` john
2016-02-23 14:19   ` Jason
2016-02-23 14:18 ` Jason
2016-02-23 14:44   ` list
2016-02-23 15:03     ` Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160223100707.GG1766@serenity.lan \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).