[PATCH 1/1] css: use less blurry icon for external link

[PATCH 1/1] css: use less blurry icon for external link

[list]

From: Christian Hesse <mail at eworm.de>

Your mileage may vary, but for me the old icon looks blurry. The new
one is character 0xf08e from OTF font awsome in size 10.
The icon color is black, gray level is adjusted via opacity.

Signed-off-by: Christian Hesse <mail at eworm.de>
---
 cgit.css | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/cgit.css b/cgit.css
index 50f6587..f6f6e7c 100644
--- a/cgit.css
+++ b/cgit.css
@@ -86,7 +86,8 @@ div#cgit table.tabs td a.active {
 }
 
 div#cgit table.tabs a[href^="http://"]:after, div#cgit table.tabs a[href^="https://"]:after {
-	content: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAQAAAAnOwc2AAAAAnNCSVQICFXsRgQAAAAJcEhZcwAAABQAAAAUAVyMgXwAAAAZdEVYdFNvZnR3YXJlAHd3dy5pbmtzY2FwZS5vcmeb7jwaAAAAeklEQVQI12NoYCu3q3ABwXL98vTy/0D4jaF8XXldRRoYejAwlu8BCTOU72SAg4q08j/le0GC22BC5anlfyrSGBiBGCZYllz+pywLJg8WLOMtf1GeCjRgI5IgSBhMboUIHq40r1CCQrfyDRAV6uXdZTMhsKKlVIIBFwAAVeg4KFYK95cAAAAASUVORK5CYII=);
+	content: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAYAAACNMs+9AAAABmJLR0QA/wD/AP+gvaeTAAAACXBIWXMAAAsTAAALEwEAmpwYAAAAB3RJTUUH4AIXCQ0GPoJtkwAAAB1pVFh0Q29tbWVudAAAAAAAQ3JlYXRlZCB3aXRoIEdJTVBkLmUHAAAAg0lEQVQY05XPsQkCQRSE4e9OY61Ae7AGAxMT7cKKrgIrUMFMA8HUAuzAxAKUNdmFx7EX+KJhZvh50xi+JTZZvxusscMolG7Y44p5MU8YV4gzPJGQ2iw+ldIFLyzwgOMA6Y5JMdteaRpIK2xjGIlNHlZI5xL0RyR0IfvG4qHyZ6F3/r0fA3QYU9MQfpcAAAAASUVORK5CYII=);
+	opacity: 0.5;
 	margin: 0 0 0 5px;
 }
 
-- 
2.7.1

[PATCH 1/1] css: use less blurry icon for external link

[john]

On Tue, Feb 23, 2016 at 10:47:25AM +0100, Christian Hesse wrote:
> Your mileage may vary, but for me the old icon looks blurry. The new
> one is character 0xf08e from OTF font awsome in size 10.
> The icon color is black, gray level is adjusted via opacity.

What's the licensing status of individual glyphs from Font Awesome?
IANAL but my reading of the OFL is that it's not compatible with the
GPL.

The nice thing about the icon from Wikipedia is that it's already
licensed under the GPLv2 so we don't have to worry about whether it's
compatible (although it might be a good idea to credit the source in a
comment).

> Signed-off-by: Christian Hesse <mail at eworm.de>
> ---
>  cgit.css | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/cgit.css b/cgit.css
> index 50f6587..f6f6e7c 100644
> --- a/cgit.css
> +++ b/cgit.css
> @@ -86,7 +86,8 @@ div#cgit table.tabs td a.active {
>  }
>  
>  div#cgit table.tabs a[href^="http://"]:after, div#cgit table.tabs a[href^="https://"]:after {
> -	content: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAQAAAAnOwc2AAAAAnNCSVQICFXsRgQAAAAJcEhZcwAAABQAAAAUAVyMgXwAAAAZdEVYdFNvZnR3YXJlAHd3dy5pbmtzY2FwZS5vcmeb7jwaAAAAeklEQVQI12NoYCu3q3ABwXL98vTy/0D4jaF8XXldRRoYejAwlu8BCTOU72SAg4q08j/le0GC22BC5anlfyrSGBiBGCZYllz+pywLJg8WLOMtf1GeCjRgI5IgSBhMboUIHq40r1CCQrfyDRAV6uXdZTMhsKKlVIIBFwAAVeg4KFYK95cAAAAASUVORK5CYII=);
> +	content: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAYAAACNMs+9AAAABmJLR0QA/wD/AP+gvaeTAAAACXBIWXMAAAsTAAALEwEAmpwYAAAAB3RJTUUH4AIXCQ0GPoJtkwAAAB1pVFh0Q29tbWVudAAAAAAAQ3JlYXRlZCB3aXRoIEdJTVBkLmUHAAAAg0lEQVQY05XPsQkCQRSE4e9OY61Ae7AGAxMT7cKKrgIrUMFMA8HUAuzAxAKUNdmFx7EX+KJhZvh50xi+JTZZvxusscMolG7Y44p5MU8YV4gzPJGQ2iw+ldIFLyzwgOMA6Y5JMdteaRpIK2xjGIlNHlZI5xL0RyR0IfvG4qHyZ6F3/r0fA3QYU9MQfpcAAAAASUVORK5CYII=);
> +	opacity: 0.5;
>  	margin: 0 0 0 5px;
>  }
>  

[PATCH 1/1] css: use less blurry icon for external link

[list]

John Keeping <john at keeping.me.uk> on Tue, 2016/02/23 10:07:
> On Tue, Feb 23, 2016 at 10:47:25AM +0100, Christian Hesse wrote:
> > Your mileage may vary, but for me the old icon looks blurry. The new
> > one is character 0xf08e from OTF font awsome in size 10.
> > The icon color is black, gray level is adjusted via opacity.  
> 
> What's the licensing status of individual glyphs from Font Awesome?
> IANAL but my reading of the OFL is that it's not compatible with the
> GPL.

What we have is the icon from awesome font, no?
Probably scaled down from one of the example images?

http://fortawesome.github.io/Font-Awesome/icon/external-link/

> The nice thing about the icon from Wikipedia is that it's already
> licensed under the GPLv2 so we don't have to worry about whether it's
> compatible (although it might be a good idea to credit the source in a
> comment).

The wikipedia icon looks different.

https://commons.wikimedia.org/wiki/File:Icon_External_Link.png
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20160223/7556e876/attachment.asc>

[PATCH 1/1] css: use less blurry icon for external link

[john]

On Tue, Feb 23, 2016 at 11:14:39AM +0100, Christian Hesse wrote:
> John Keeping <john at keeping.me.uk> on Tue, 2016/02/23 10:07:
> > On Tue, Feb 23, 2016 at 10:47:25AM +0100, Christian Hesse wrote:
> > > Your mileage may vary, but for me the old icon looks blurry. The new
> > > one is character 0xf08e from OTF font awsome in size 10.
> > > The icon color is black, gray level is adjusted via opacity.  
> > 
> > What's the licensing status of individual glyphs from Font Awesome?
> > IANAL but my reading of the OFL is that it's not compatible with the
> > GPL.
> 
> What we have is the icon from awesome font, no?
> Probably scaled down from one of the example images?
> 
> http://fortawesome.github.io/Font-Awesome/icon/external-link/

I didn't realise that, I pointed at Wikipedia when I suggested using an
icon in CSS :-)

There's a comment on the FontAwesome GitHub repo [1] that gives a lot of
sources indicating that the OFL is not compatible with the GPL so I
think we should be using something else here, at least in the main
distribution.  If individual sites want to do something different that's
their choice.

[1] https://github.com/FortAwesome/Font-Awesome/issues/1124#issuecomment-28703032

> > The nice thing about the icon from Wikipedia is that it's already
> > licensed under the GPLv2 so we don't have to worry about whether it's
> > compatible (although it might be a good idea to credit the source in a
> > comment).
> 
> The wikipedia icon looks different.
> 
> https://commons.wikimedia.org/wiki/File:Icon_External_Link.png

[PATCH 1/1] css: use less blurry icon for external link

[Jason]

According the the FSF, we're allowed to distribute parts of it as we
are doing alongside cgit, without changing the status of cgit.

[PATCH 1/1] css: use less blurry icon for external link

[Jason]

Thanks. I did actually do this myself in inkscape from an svg
representation of the font, but I must have hit the anti aliasing
button or something. Also, the opacity is much better, thanks.

I merged this, and also ran the png through pngcrush before.

[PATCH 1/1] css: use less blurry icon for external link

[list]

"Jason A. Donenfeld" <Jason at zx2c4.com> on Tue, 2016/02/23 15:18:
> Thanks. I did actually do this myself in inkscape from an svg
> representation of the font, but I must have hit the anti aliasing
> button or something. Also, the opacity is much better, thanks.
> 
> I merged this, and also ran the png through pngcrush before.

Did pngcrush compress more? I tried optipng, but it did not change the file.
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20160223/6ee66575/attachment.asc>

[PATCH 1/1] css: use less blurry icon for external link

[Jason]

On Tue, Feb 23, 2016 at 3:44 PM, Christian Hesse <list at eworm.de> wrote:
> Did pngcrush compress more? I tried optipng, but it did not change the file.

It managed to shave off a few bytes, yes.