From: john at keeping.me.uk (John Keeping)
Subject: [PATCH 1/2] ui-log: Do not always emit decoration span
Date: Sun, 28 Feb 2016 12:40:22 +0000 [thread overview]
Message-ID: <20160228124022.GY1766@serenity.lan> (raw)
In-Reply-To: <1456520251-22349-2-git-send-email-tim.nordell@logicpd.com>
On Fri, Feb 26, 2016 at 02:57:30PM -0600, Tim Nordell wrote:
> The decoration span does not need to be emited if there aren't
> any decorations to show. This modification saves slightly
> on bandwidth.
>
> Signed-off-by: Tim Nordell <tim.nordell at logicpd.com>
>
> diff --git a/ui-log.c b/ui-log.c
> index 0a3938b..62881ce 100644
> --- a/ui-log.c
> +++ b/ui-log.c
> @@ -61,6 +61,8 @@ void show_commit_decorations(struct commit *commit)
>
> buf[sizeof(buf) - 1] = 0;
> deco = get_name_decoration(&commit->object);
> + if(!deco)
style nit: if (!deco)
otherwise:
Reviewed-by: John Keeping <john at keeping.me.uk>
> + return;
> html("<span class='decoration'>");
> while (deco) {
> if (starts_with(deco->name, "refs/heads/")) {
> --
> 2.4.9
>
> _______________________________________________
> CGit mailing list
> CGit at lists.zx2c4.com
> http://lists.zx2c4.com/mailman/listinfo/cgit
next prev parent reply other threads:[~2016-02-28 12:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 20:57 [PATCH 0/2] ui-log: Don't print out unknown decoration types tim.nordell
2016-02-26 20:57 ` [PATCH 1/2] ui-log: Do not always emit decoration span tim.nordell
2016-02-28 12:40 ` john [this message]
2016-05-12 15:16 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160228124022.GY1766@serenity.lan \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).