From: john at keeping.me.uk (John Keeping)
Subject: [PATCH 1/1] ui-shared: Simplify cgit_print_error_page() logic
Date: Wed, 11 May 2016 19:31:59 +0100 [thread overview]
Message-ID: <20160511183159.GB4296@serenity.lan> (raw)
In-Reply-To: <1462989009-3399-1-git-send-email-wub@partyvan.eu>
On Wed, May 11, 2016 at 05:50:09PM +0000, Juuso Lapinlampi wrote:
> ---
> This may be a little controversial, but right now is there a reason not
> to do this?
No, I think this makes sense (although again we need your
signed-off-by).
Reviewed-by: John Keeping <john at keeping.me.uk>
> ui-shared.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/ui-shared.c b/ui-shared.c
> index 9a38aa9..d9541f0 100644
> --- a/ui-shared.c
> +++ b/ui-shared.c
> @@ -792,13 +792,11 @@ void cgit_print_error_page(int code, const char *msg, const char *fmt, ...)
> ctx.page.expires = ctx.cfg.cache_dynamic_ttl;
> ctx.page.status = code;
> ctx.page.statusmsg = msg;
> - cgit_print_http_headers();
> - cgit_print_docstart();
> - cgit_print_pageheader();
> + cgit_print_layout_start()
> va_start(ap, fmt);
> cgit_vprint_error(fmt, ap);
> va_end(ap);
> - cgit_print_docend();
> + cgit_print_layout_end();
> }
>
> void cgit_print_layout_start(void)
> --
> 2.8.1
>
> _______________________________________________
> CGit mailing list
> CGit at lists.zx2c4.com
> http://lists.zx2c4.com/mailman/listinfo/cgit
next prev parent reply other threads:[~2016-05-11 18:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 17:50 wub
2016-05-11 18:31 ` john [this message]
2016-05-12 15:26 ` Jason
2016-05-12 15:38 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511183159.GB4296@serenity.lan \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).