From mboxrd@z Thu Jan 1 00:00:00 1970
From: john at keeping.me.uk (John Keeping)
Date: Wed, 11 May 2016 19:56:19 +0100
Subject: [PATCH 1/5] ui-shared: HTML-ize DOCTYPE and
In-Reply-To: <1462989858-15825-2-git-send-email-wub@partyvan.eu>
References: <1462989858-15825-1-git-send-email-wub@partyvan.eu>
<1462989858-15825-2-git-send-email-wub@partyvan.eu>
Message-ID: <20160511185619.GG4296@serenity.lan>
On Wed, May 11, 2016 at 06:04:14PM +0000, Juuso Lapinlampi wrote:
> Get rid of the XHTML headers, bringing cgit slowly to the modern age of
> HTML.
This seems like a reasonable aim, but don't we need to actually *be*
HTML(5?) as well in order to do this? Currently we close and
tags even though HTML is explicit that this shouldn't be done.
I think we need to fix all of those as well if we're going to claim to
be HTML rather than XHTML. I suspect that would be a bit big to review
as a single patch, but I certainly think that it should be applied as a
single patch series.
> ---
> ui-shared.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/ui-shared.c b/ui-shared.c
> index 9a38aa9..1ded2d6 100644
> --- a/ui-shared.c
> +++ b/ui-shared.c
> @@ -12,8 +12,7 @@
> #include "html.h"
>
> static const char cgit_doctype[] =
> -" -" \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\">\n";
> +""\n";
>
> static char *http_date(time_t t)
> {
> @@ -723,7 +722,7 @@ void cgit_print_docstart(void)
>
> char *host = cgit_hosturl();
> html(cgit_doctype);
> - html("\n");
> + html("\n");
> html("\n");
> html("");
> html_txt(ctx.page.title);
> --
> 2.8.1
>
> _______________________________________________
> CGit mailing list
> CGit at lists.zx2c4.com
> http://lists.zx2c4.com/mailman/listinfo/cgit