List for cgit developers and users
 help / color / mirror / Atom feed
From: wub at partyvan.eu (Juuso Lapinlampi)
Subject: [PATCH 1/1] ui-shared: Use CRLF in HTTP headers as per RFC 7230
Date: Wed, 11 May 2016 19:38:24 +0000	[thread overview]
Message-ID: <20160511193824.GB9158@partyvan.eu> (raw)
In-Reply-To: <20160511183049.GA4296@serenity.lan>

On Wed, May 11, 2016 at 07:30:49PM +0100, John Keeping wrote:
> Missing sign-off; see http://developercertificate.org/ for what this
> means.

I am aware, but small changes like these are not generally recognized to
fit the threshold of originality for copyright protection. Thus, the
idea of Signed-off is quite often silly.

There are arguably cases where Signed-off is useful, for example, where
the maintainer has changed the commit message of the author or
co-authored code into the patch. An example from another repository I
maintain:

    commit d17c8830a8cb97fb48201990f5d57eb7a7b9e4ee
    Author: Eliot Whalan <ewhal at pantsu.cat>
    Date:   Thu Jan 21 11:41:17 2016 +1000
    
        Remove unused page specific CSS (old, ded)
    
        The tools page has only had alive and maintained tools on it since Pomf
        2.0.0. Ded and old tools have been removed in commit
        627937d0fa632a677f278af467886915c0a36f35.
    
        It is anticipated that these style rules will be never used again. If we
        did, we can add them back later: "you aren't gonna need it" (YAGNI). If
        it's dead, you should probably remove the tool from the tools page
        instead of beating a dead horse.
    
        [wub at partyvan.eu: Modified Git commit message, as discussed]
        Signed-off-by: Juuso Lapinlampi <wub at partyvan.eu>

In this case, the sole author is me and I don't think it's sensible to
use Signed-off-by. Not at least until Git makes it a default behavior.

I am the author of these patches with my name and email address in Git's
"Author:" field.

(Off-topic: Notice how the copyright headers are stuck in year 2014 in
the source file. Year ranges (2006-2014) have never been tested in court
as far as I'm aware, but comma seperated copyright years (2006, 2007,
2008, [...]) have been as far as I'm aware.)


  parent reply	other threads:[~2016-05-11 19:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-11 17:48 wub
2016-05-11 18:30 ` john
2016-05-11 19:31   ` john
2016-05-11 19:38   ` wub [this message]
2016-05-11 19:57     ` john
2016-05-11 20:15       ` wub
2016-05-12 10:23         ` john
2016-05-12 15:45     ` Jason
2016-05-12 15:45 ` Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160511193824.GB9158@partyvan.eu \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).